fix: add check to verify for newline char in zone files

This commit is contained in:
Markus Pesch 2024-04-29 21:57:30 +02:00
parent ead1284611
commit 5bb333929b
Signed by: volker.raschek
GPG Key ID: 852BCC170D81A982
2 changed files with 22 additions and 1 deletions

View File

@ -16,7 +16,7 @@
- name: "Template view {{ view.name }}" - name: "Template view {{ view.name }}"
ansible.builtin.template: ansible.builtin.template:
src: "{{ inventory_hostname }}/etc/named/{{ zone.file }}.j2" src: "{{ inventory_hostname }}/etc/named/{{ zone.file }}.j2"
dest: "{{ bind_config_directory }}/{{ zone.file }}" dest: "{{ bind_config_directory + '/' + zone.file }}"
owner: "{{ bind_unix_user }}" owner: "{{ bind_unix_user }}"
group: "{{ bind_unix_group }}" group: "{{ bind_unix_group }}"
mode: "0644" mode: "0644"
@ -26,3 +26,11 @@
loop_var: zone loop_var: zone
when: zone.type == 'master' when: zone.type == 'master'
notify: Restart named notify: Restart named
- name: Check if last character in zone files is a newline
ansible.builtin.include_tasks: verify_zone_file.yml
with_items:
- "{{ view.zones }}"
loop_control:
loop_var: zone
when: zone.type == 'master'

View File

@ -0,0 +1,13 @@
---
- name: "Read the last character of DNS Zonefile: {{ bind_config_directory + '/' + zone.file }}"
ansible.builtin.command:
cmd: "tail --bytes 1 {{ bind_config_directory + '/' + zone.file }}"
register: _bind9_zone_last_character
changed_when: _bind9_zone_last_character.rc == 0
failed_when: _bind9_zone_last_character.rc > 0
- name: "Fail when the last character of DNS zone file is not a newline: {{ bind_config_directory + '/' + zone.file }}"
ansible.builtin.fail:
msg: "Last character of DNS zone file is not a newline: {{ bind_config_directory + '/' + zone.file }}"
failed_when: _bind9_zone_last_character.stdout | regex_search('.+') | default(false)