5 Commits

Include renames

Author	SHA1	Message	Date
volker.raschekandCopilot	c34b59633c	fix(tasks): stop reporting a change when looking up the btrfs device ... `findmnt` only reads the mount table, but the task declared `changed_when` on a successful return code and therefore reported a change on every single run. Any btrfs backed user made the whole play non idempotent, which an idempotence check would flag as soon as one exists. The `failed_when` on a non zero return code is dropped along with it, since that is exactly what the command module does by default. Co-authored-by: Copilot <copilot@github.com>	2026-09-09 21:39:42 +02:00
volker.raschekandCopilot	68ee8ebbcd	fix(tasks)!: repair the broken guards in the unix user creation ... Several defects accumulated in this task file and are fixed together, because they overlap in the same code paths. The debug task was dead code. Its `msg` lacked the Jinja delimiters and would have printed the literal string `_unix_users_btrfs_device.stdout`, and it was gated on `_unix_users_debug`, a variable that is neither defined in defaults nor documented anywhere. It is removed instead of repaired, since the failure path already reports the device. The four `ansible.builtin.user` tasks differed only in whether `uid` and `groups` were passed. They are collapsed into a single task using `default(omit)`, which removes the risk that a fix lands in one of the four copies only. This also fixes `comment`, which dereferenced `unix_user.value.name` unconditionally and aborted for every user that did not set the undocumented and supposedly optional key. Two conditions compared a length against zero with `>=`, which is true for any list. As a result an empty `ssh.config` still produced a config file, and the removal counterpart never triggered. The create and remove pair for `.ssh/config` now mirrors the one already used for `authorized_keys`. The private key source was resolved through `{{ playbook_dir }}`, while the authorized key lookup in the template uses the regular relative search path. Both now use the same mechanism, which is a superset of the previous location, so existing playbook layouts keep working, and the role becomes testable from a molecule scenario. BREAKING CHANGE: The `.ssh` directory is only created when a user actually declares an `ssh` key, and an empty `ssh.config` list now removes the client config instead of writing an empty one. Users who relied on the role to pre create an empty `~/.ssh` have to declare `ssh: {}` explicitly. Co-authored-by: Copilot <copilot@github.com>	2026-09-09 21:39:42 +02:00
volker.raschekandCopilot	91ba7845da	fix(tasks): chown the btrfs home directory only after the user exists ... The btrfs block chowned the freshly created subvolume to the user right after `btrfs_subvolume`, but the four `ansible.builtin.user` tasks that actually create that user run further below. On a first run the chown therefore aborted with an invalid user error, which made the whole btrfs code path unusable. The task is removed rather than reordered, because an identical chown already exists in the "Adapt permissions and copy skel" block below the user creation. That block also runs the skel copy first, so the file ownership set there is not overwritten afterwards. The subvolume simply stays root owned for a few tasks longer, which a comment now records. Co-authored-by: Copilot <copilot@github.com>	2026-09-09 21:39:42 +02:00
volker.raschek	e4c12b9856	fix: set btrfs device	2025-11-22 23:42:42 +01:00
volker.raschek	22048124fd	refac: use .yaml instead of .yml extension	2025-10-25 12:38:00 +02:00