fix(config): support netrc

unittests/deployment/deployment.yaml

@@ -464,65 +464,3 @@ tests:
         mountPath: /usr/lib/athens-proxy/data
     template: templates/athens-proxy/deployment.yaml
 
-- it: Test persistent volume claim
-  set:
-    persistence.enabled: true
-  asserts:
-    - contains:
-        path: spec.template.spec.containers[0].env
-        content:
-          name: ATHENS_STORAGE_TYPE
-          value: disk
-      template: templates/athens-proxy/deployment.yaml
-    - contains:
-        path: spec.template.spec.containers[0].env
-        content:
-          name: ATHENS_DISK_STORAGE_ROOT
-          value: /var/www/athens-proxy/data
-      template: templates/athens-proxy/deployment.yaml
-    - contains:
-        path: spec.template.spec.containers[0].volumeMounts
-        content:
-          name: data
-          mountPath: /var/www/athens-proxy/data
-      template: templates/athens-proxy/deployment.yaml
-    - contains:
-        path: spec.template.spec.volumes
-        content:
-          name: data
-          persistentVolumeClaim:
-            claimName: athens-proxy-unittest-data
-      template: templates/athens-proxy/deployment.yaml
-
-- it: Test existing persistent volume claim
-  set:
-    persistence.enabled: true
-    persistence.data.mountPath: "/mnt/go-proxy/data"
-    persistence.data.existingPersistentVolumeClaim.enabled: true
-    persistence.data.existingPersistentVolumeClaim.persistentVolumeClaimName: "my-special-pvc"
-  asserts:
-    - contains:
-        path: spec.template.spec.containers[0].env
-        content:
-          name: ATHENS_STORAGE_TYPE
-          value: disk
-      template: templates/athens-proxy/deployment.yaml
-    - contains:
-        path: spec.template.spec.containers[0].env
-        content:
-          name: ATHENS_DISK_STORAGE_ROOT
-          value: /mnt/go-proxy/data
-      template: templates/athens-proxy/deployment.yaml
-    - contains:
-        path: spec.template.spec.containers[0].volumeMounts
-        content:
-          name: data
-          mountPath: /mnt/go-proxy/data
-      template: templates/athens-proxy/deployment.yaml
-    - contains:
-        path: spec.template.spec.volumes
-        content:
-          name: data
-          persistentVolumeClaim:
-            claimName: my-special-pvc
-      template: templates/athens-proxy/deployment.yaml

unittests/deployment/netrc.yaml

@@ -0,0 +1,80 @@
+chart:
+  appVersion: 0.1.0
+  version: 0.1.0
+suite: Deployment template
+release:
+  name: athens-proxy-unittest
+  namespace: testing
+templates:
+- templates/athens-proxy/deployment.yaml
+tests:
+- it: Rendering default without mounted netrc secret
+  asserts:
+    - notContains:
+        path: spec.template.spec.containers[0].volumeMounts
+        content:
+          name: netrc
+          mountPath: /root
+    - notContains:
+        path: spec.template.spec.volumes
+        content:
+          name: secrets
+          projected:
+            sources:
+            - secret:
+                items:
+                - key: .netrc
+                  path: .netrc
+                  mode: 0600
+                name: athens-proxy-unittest-netrc
+
+- it: Rendering default with mounted netrc secret
+  set:
+    config.netrc.enabled: true
+    persistence.enabled: true
+  asserts:
+    - contains:
+        path: spec.template.spec.containers[0].volumeMounts
+        content:
+          name: secrets
+          mountPath: /root/.netrc
+          subPath: .netrc
+    - contains:
+        path: spec.template.spec.volumes
+        content:
+          name: secrets
+          projected:
+            sources:
+            - secret:
+                items:
+                - key: .netrc
+                  path: .netrc
+                  mode: 0600
+                name: athens-proxy-unittest-netrc
+
+- it: Rendering with custom netrc secret
+  set:
+    config.netrc.enabled: true
+    config.netrc.existingSecret.enabled: true
+    config.netrc.existingSecret.secretName: "my-custom-secret"
+    config.netrc.existingSecret.netrcKey: "my-netrc-key"
+    persistence.enabled: true
+  asserts:
+    - contains:
+        path: spec.template.spec.containers[0].volumeMounts
+        content:
+          name: secrets
+          mountPath: /root/.netrc
+          subPath: .netrc
+    - contains:
+        path: spec.template.spec.volumes
+        content:
+          name: secrets
+          projected:
+            sources:
+            - secret:
+                items:
+                - key: my-netrc-key
+                  path: .netrc
+                  mode: 0600
+                name: my-custom-secret

unittests/deployment/persistentVolumeClaim.yaml

@@ -0,0 +1,73 @@
+chart:
+  appVersion: 0.1.0
+  version: 0.1.0
+suite: Deployment template
+release:
+  name: athens-proxy-unittest
+  namespace: testing
+templates:
+- templates/athens-proxy/deployment.yaml
+tests:
+- it: Test persistent volume claim
+  set:
+    persistence.enabled: true
+  asserts:
+    - contains:
+        path: spec.template.spec.containers[0].env
+        content:
+          name: ATHENS_STORAGE_TYPE
+          value: disk
+      template: templates/athens-proxy/deployment.yaml
+    - contains:
+        path: spec.template.spec.containers[0].env
+        content:
+          name: ATHENS_DISK_STORAGE_ROOT
+          value: /var/www/athens-proxy/data
+      template: templates/athens-proxy/deployment.yaml
+    - contains:
+        path: spec.template.spec.containers[0].volumeMounts
+        content:
+          name: data
+          mountPath: /var/www/athens-proxy/data
+      template: templates/athens-proxy/deployment.yaml
+    - contains:
+        path: spec.template.spec.volumes
+        content:
+          name: data
+          persistentVolumeClaim:
+            claimName: athens-proxy-unittest-data
+      template: templates/athens-proxy/deployment.yaml
+
+- it: Test existing persistent volume claim
+  set:
+    config.netrc.enabled: true
+    persistence.enabled: true
+    persistence.data.mountPath: "/mnt/go-proxy/data"
+    persistence.data.existingPersistentVolumeClaim.enabled: true
+    persistence.data.existingPersistentVolumeClaim.persistentVolumeClaimName: "my-special-pvc"
+  asserts:
+    - contains:
+        path: spec.template.spec.containers[0].env
+        content:
+          name: ATHENS_STORAGE_TYPE
+          value: disk
+      template: templates/athens-proxy/deployment.yaml
+    - contains:
+        path: spec.template.spec.containers[0].env
+        content:
+          name: ATHENS_DISK_STORAGE_ROOT
+          value: /mnt/go-proxy/data
+      template: templates/athens-proxy/deployment.yaml
+    - contains:
+        path: spec.template.spec.containers[0].volumeMounts
+        content:
+          name: data
+          mountPath: /mnt/go-proxy/data
+      template: templates/athens-proxy/deployment.yaml
+    - contains:
+        path: spec.template.spec.volumes
+        content:
+          name: data
+          persistentVolumeClaim:
+            claimName: my-special-pvc
+      template: templates/athens-proxy/deployment.yaml

unittests/secrets/netrc.yaml

@@ -8,14 +8,22 @@ release:
 templates:
 - templates/athens-proxy/secretNetRC.yaml
 tests:
+- it: Skip rendering by default
+  asserts:
+  - hasDocuments:
+      count: 0
+
 - it: Skip rendering by using existing secret.
   set:
+    config.netrc.enabled: true
     config.netrc.existingSecret.enabled: true
   asserts:
   - hasDocuments:
       count: 0
 
 - it: Rendering netrc secret with default values.
+  set:
+    config.netrc.enabled: true
   asserts:
   - hasDocuments:
       count: 1
@@ -52,6 +60,7 @@ tests:
 
 - it: Rendering netrc secret with custom values.
   set:
+    config.netrc.enabled: true
     config.netrc.secret.content: |
       default github.com hugo password kinnock
       default api.github.com hugo password kinnock
@@ -64,6 +73,7 @@ tests:
 
 - it: Rendering custom annotations and labels.
   set:
+    config.netrc.enabled: true
     config.netrc.secret.annotations:
       foo: bar
       bar: foo