Compare commits

..

2 Commits

Author SHA1 Message Date
32bc80cc49 chore(deps): update actions/checkout action to v4.3.0
All checks were successful
Lint Golang files / Run golang CI linter (stable, ubuntu-latest-amd64) (push) Successful in 11s
Run Golang tests / Run unit tests (stable, ubuntu-latest-amd64) (push) Successful in 5s
Lint Golang files / Run golang CI linter (stable, ubuntu-latest-amd64) (pull_request) Successful in 12s
Run Golang tests / Run unit tests (stable, ubuntu-latest-amd64) (pull_request) Successful in 5s
Lint Markdown files / Run markdown linter (pull_request) Successful in 4s
Lint Golang files / Run golang CI linter (stable, ubuntu-latest-arm64) (push) Successful in 41s
Run Golang tests / Run unit tests (stable, ubuntu-latest-arm64) (push) Successful in 18s
Lint Golang files / Run golang CI linter (stable, ubuntu-latest-arm64) (pull_request) Successful in 40s
Run Golang tests / Run unit tests (stable, ubuntu-latest-arm64) (pull_request) Successful in 21s
2025-08-12 12:10:55 +00:00
b0c90c4cb3 fix(lint): be compliant with golangci-lint
All checks were successful
Lint Golang files / Run golang CI linter (stable, ubuntu-latest-amd64) (push) Successful in 20s
Lint Markdown files / Run markdown linter (push) Successful in 3s
Run Golang tests / Run unit tests (stable, ubuntu-latest-amd64) (push) Successful in 35s
Lint Golang files / Run golang CI linter (stable, ubuntu-latest-arm64) (push) Successful in 1m3s
Run Golang tests / Run unit tests (stable, ubuntu-latest-arm64) (push) Successful in 19s
2025-08-12 13:53:32 +02:00
3 changed files with 28 additions and 28 deletions

View File

@ -2,7 +2,6 @@ package cmd
import (
"fmt"
"io/ioutil"
"log"
"os"
@ -59,7 +58,8 @@ func runE(cmd *cobra.Command, args []string) error {
return fmt.Errorf("can not find file: %v", file)
}
f, err := ioutil.ReadFile(file)
// #nosec G304
f, err := os.ReadFile(file)
if err != nil {
return fmt.Errorf("can not read file %v: %v", file, err)
}

View File

@ -3,11 +3,11 @@ package hub
import "errors"
var (
errorFailedToCreateRequest = errors.New("failed to create http request")
errorFailedToParseJSON = errors.New("failed to parse json")
errorFailedToParseURL = errors.New("failed to parse url")
errorFailedToSendRequest = errors.New("failed to send http request")
errorNoNamespaceDefined = errors.New("no Namespace defined")
errorNoRepositoryDefined = errors.New("no Repository defined")
errorUnexpectedHTTPStatuscode = errors.New("unexpected HTTP-Statuscode")
errFailedToCreateRequest = errors.New("failed to create http request")
errFailedToParseJSON = errors.New("failed to parse json")
errFailedToParseURL = errors.New("failed to parse url")
errFailedToSendRequest = errors.New("failed to send http request")
errNoNamespaceDefined = errors.New("no Namespace defined")
errNoRepositoryDefined = errors.New("no Repository defined")
errUnexpectedHTTPStatuscode = errors.New("unexpected HTTP-Statuscode")
)

View File

@ -25,22 +25,22 @@ type Hub struct {
func (h *Hub) GetRepository(namespace string, name string) (*types.Repository, error) {
if len(namespace) <= 0 {
return nil, errorNoNamespaceDefined
return nil, errNoNamespaceDefined
}
if len(name) <= 0 {
return nil, errorNoRepositoryDefined
return nil, errNoRepositoryDefined
}
rawURL := fmt.Sprintf("%v/repositories/%v/%v", dockerHubAPI, namespace, name)
url, err := url.Parse(rawURL)
if err != nil {
return nil, fmt.Errorf("%v: %v", errorFailedToParseURL, err)
return nil, fmt.Errorf("%v: %v", errFailedToParseURL, err)
}
req, err := http.NewRequest(http.MethodGet, url.String(), nil)
if err != nil {
return nil, fmt.Errorf("%v: %v", errorFailedToCreateRequest, err)
return nil, fmt.Errorf("%v: %v", errFailedToCreateRequest, err)
}
if h.token == nil {
@ -54,18 +54,18 @@ func (h *Hub) GetRepository(namespace string, name string) (*types.Repository, e
resp, err := h.client.Do(req)
if err != nil {
return nil, fmt.Errorf("%v: %v", errorFailedToSendRequest, err)
return nil, fmt.Errorf("%v: %v", errFailedToSendRequest, err)
}
defer func() { _ = resp.Body.Close() }()
if resp.StatusCode != http.StatusOK {
return nil, fmt.Errorf("%v: expect %v, received %v", errorUnexpectedHTTPStatuscode, http.StatusOK, resp.StatusCode)
return nil, fmt.Errorf("%v: expect %v, received %v", errUnexpectedHTTPStatuscode, http.StatusOK, resp.StatusCode)
}
repository := new(types.Repository)
jsonDecoder := json.NewDecoder(resp.Body)
if err := jsonDecoder.Decode(repository); err != nil {
return nil, fmt.Errorf("%v: %v", errorFailedToParseJSON, err)
return nil, fmt.Errorf("%v: %v", errFailedToParseJSON, err)
}
return repository, nil
@ -75,30 +75,30 @@ func (h *Hub) getToken() (*types.Token, error) {
loginBuffer := new(bytes.Buffer)
jsonEncoder := json.NewEncoder(loginBuffer)
if err := jsonEncoder.Encode(h.credentials); err != nil {
return nil, fmt.Errorf("%v: %v", errorFailedToParseJSON, err)
return nil, fmt.Errorf("%v: %v", errFailedToParseJSON, err)
}
rawURL := fmt.Sprintf("%v/users/login/", dockerHubAPI)
req, err := http.NewRequest(http.MethodPost, rawURL, loginBuffer)
if err != nil {
return nil, fmt.Errorf("%v: %v", errorFailedToCreateRequest, err)
return nil, fmt.Errorf("%v: %v", errFailedToCreateRequest, err)
}
req.Header.Add("Content-Type", "application/json")
resp, err := h.client.Do(req)
if err != nil {
return nil, fmt.Errorf("%v: %v", errorFailedToCreateRequest, err)
return nil, fmt.Errorf("%v: %v", errFailedToCreateRequest, err)
}
defer func() { _ = resp.Body.Close() }()
if resp.StatusCode != http.StatusOK {
return nil, fmt.Errorf("%v: expect %v, received %v", errorUnexpectedHTTPStatuscode, http.StatusOK, resp.StatusCode)
return nil, fmt.Errorf("%v: expect %v, received %v", errUnexpectedHTTPStatuscode, http.StatusOK, resp.StatusCode)
}
token := new(types.Token)
jsonDecoder := json.NewDecoder(resp.Body)
if err := jsonDecoder.Decode(token); err != nil {
return nil, fmt.Errorf("%v: %v", errorFailedToParseJSON, err)
return nil, fmt.Errorf("%v: %v", errFailedToParseJSON, err)
}
return token, nil
@ -108,11 +108,11 @@ func (h *Hub) getToken() (*types.Token, error) {
func (h *Hub) PatchRepository(repository *types.Repository) (*types.Repository, error) {
if len(repository.Namespcace) <= 0 {
return nil, errorNoNamespaceDefined
return nil, errNoNamespaceDefined
}
if len(repository.Name) <= 0 {
return nil, errorNoRepositoryDefined
return nil, errNoRepositoryDefined
}
if h.token == nil {
@ -127,7 +127,7 @@ func (h *Hub) PatchRepository(repository *types.Repository) (*types.Repository,
rawURL := fmt.Sprintf("%v/repositories/%v/%v", dockerHubAPI, repository.Namespcace, repository.Name)
patchURL, err := url.Parse(rawURL)
if err != nil {
return nil, fmt.Errorf("%v: %v", errorFailedToParseURL, err)
return nil, fmt.Errorf("%v: %v", errFailedToParseURL, err)
}
data := &url.Values{}
@ -136,24 +136,24 @@ func (h *Hub) PatchRepository(repository *types.Repository) (*types.Repository,
req, err := http.NewRequest(http.MethodPatch, patchURL.String(), nil)
if err != nil {
return nil, fmt.Errorf("%v: %v", errorFailedToCreateRequest, err)
return nil, fmt.Errorf("%v: %v", errFailedToCreateRequest, err)
}
req.Header.Set("Authorization", fmt.Sprintf("JWT %v", h.token.Token))
resp, err := h.client.Do(req)
if err != nil {
return nil, fmt.Errorf("%v: %v", errorFailedToCreateRequest, err)
return nil, fmt.Errorf("%v: %v", errFailedToCreateRequest, err)
}
defer func() { _ = resp.Body.Close() }()
if resp.StatusCode != http.StatusOK {
return nil, fmt.Errorf("%v: expect %v, received %v", errorUnexpectedHTTPStatuscode, http.StatusOK, resp.StatusCode)
return nil, fmt.Errorf("%v: expect %v, received %v", errUnexpectedHTTPStatuscode, http.StatusOK, resp.StatusCode)
}
patchedRepository := new(types.Repository)
jsonDecoder := json.NewDecoder(resp.Body)
if err := jsonDecoder.Decode(h.token); err != nil {
return nil, fmt.Errorf("%v: %v", errorFailedToParseJSON, err)
return nil, fmt.Errorf("%v: %v", errFailedToParseJSON, err)
}
return patchedRepository, nil