fix: decouple service from drone config

templates/deployment.yaml

@@ -28,9 +28,9 @@ spec:
           imagePullPolicy: {{ .Values.image.pullPolicy }}
           livenessProbe:
             httpGet:
-              scheme: {{ .Values.config.DRONE_SERVER_PROTO | upper | default "HTTP" }}
+              scheme: HTTP
               path: /healthz
-              port: {{ .Values.config.DRONE_SERVER_PROTO | default "http" }}
+              port: http
           ports:
           - name: http
             containerPort: 80
@@ -40,9 +40,9 @@ spec:
             protocol: TCP
           readinessProbe:
             httpGet:
-              scheme: {{ .Values.config.DRONE_SERVER_PROTO | upper | default "HTTP" }}
+              scheme: HTTP
               path: /healthz
-              port: {{ .Values.config.DRONE_SERVER_PROTO | default "http" }}
+              port: http
           resources:
             {{- toYaml .Values.resources | nindent 12 }}
           {{- if .Values.config.DRONE_DATABASE_DRIVER | default "sqlite3" | eq "sqlite3" }}

templates/service.yaml

@@ -29,8 +29,8 @@ spec:
   type: {{ .Values.service.type }}
   ports:
     - port: {{ .Values.service.port }}
-      targetPort: {{ .Values.config.DRONE_SERVER_PROTO | default "http" }}
+      targetPort: {{ .Values.service.targetPort }}
       protocol: TCP
-      name: {{ .Values.config.DRONE_SERVER_PROTO | default "http" }}
+      name: {{ .Values.service.name }}
   selector:
     {{- include "drone.selectorLabels" . | nindent 4 }}

values.yaml

@@ -533,6 +533,8 @@ service:
   # loadBalancerIP: ""
   # loadBalancerSourceRanges: []
   # internalTrafficPolicy: "Cluster"
+  name: http
+  targetPort: 80
   type: ClusterIP
   port: 80