chore(deps): update module github.com/asaskevich/govalidator to v11

.dockerignore

@@ -1 +1 @@
-dyndns-client
+bin

.editorconfig

@@ -1,13 +1,12 @@
-# Editor configuration, see http://editorconfig.org
 root = true
 
 [*]
-charset = utf-8
-end_of_line = lf
-indent_size = 2
 indent_style = space
-insert_final_newline = false
+indent_size = 2
+end_of_line = lf
+charset = utf-8
 trim_trailing_whitespace = true
+insert_final_newline = false
 
-[{Makefile,*.go}]
+[Makefile]
-indent_style = tab
+indent_style = tab

.gitattributes

@@ -0,0 +1 @@
+**/Makefile eol=lf

.gitea/workflows/golang-tests.yaml

@@ -1,4 +1,4 @@
-name: "Run Golang tests"
+name: Golang Tests
 
 on:
   pull_request:
@@ -6,34 +6,16 @@ on:
   push:
     branches: [ '**' ]
     tags-ignore: [ '**' ]
-  workflow_dispatch: {}
 
 jobs:
-  # integration-test:
+  unittest:
-  #   name: "Run integration tests"
-  #   runs-on: ${{ matrix.os }}
-  #   strategy:
-  #     matrix:
-  #       go: [ stable ]
-  #       os: [ ubuntu-latest-amd64, ubuntu-latest-arm64 ]
-  #   steps:
-  #   - uses: actions/checkout@v4.3.0
-  #   - uses: actions/setup-go@v5.5.0
-  #     with:
-  #       go-version: ${{ matrix.go }}
-  #   - env:
-  #       GOPROXY: ${{ vars.GOPROXY }}
-  #     run: make test/integration
-
-  unit-test:
-    name: "Run unit tests"
     runs-on: ${{ matrix.os }}
     strategy:
       matrix:
         go: [ stable ]
         os: [ ubuntu-latest-amd64, ubuntu-latest-arm64 ]
     steps:
-    - uses: actions/checkout@v4.3.0
+    - uses: actions/checkout@v4.2.2
     - uses: actions/setup-go@v5.5.0
       with:
         go-version: ${{ matrix.go }}

.gitea/workflows/golangci-lint.yaml

@@ -1,4 +1,4 @@
-name: "Lint Golang files"
+name: Golang CI lint
 
 on:
   pull_request:
@@ -6,24 +6,22 @@ on:
   push:
     branches: [ '**' ]
     tags-ignore: [ '**' ]
-  workflow_dispatch: {}
 
 permissions:
   contents: read
 
 jobs:
   golangci:
-    name: "Run golang CI linter"
     runs-on: ${{ matrix.os }}
     strategy:
       matrix:
         go: [ stable ]
         os: [ ubuntu-latest-amd64, ubuntu-latest-arm64 ]
     steps:
-    - uses: actions/checkout@v4.3.0
+    - uses: actions/checkout@v4.2.2
     - uses: actions/setup-go@v5.5.0
       with:
         go-version: ${{ matrix.go }}
     - uses: golangci/golangci-lint-action@v8.0.0
       with:
-        version: v2.4.0 # renovate: datasource=github-releases depName=golangci/golangci-lint
+        version: v2.1

.gitea/workflows/markdown-linters.yaml

@@ -1,19 +1,19 @@
-name: "Lint Markdown files"
+name: Markdown linter
 
 on:
   pull_request:
     types: [ "opened", "reopened", "synchronize" ]
   push:
-    branches: [ '*' ]
+    branches: [ '**' ]
-    tags-ignore: [ '*' ]
+    tags-ignore: [ '**' ]
   workflow_dispatch: {}
 
 jobs:
   markdown-lint:
-    name: "Run markdown linter"
+    runs-on:
-    runs-on: ubuntu-latest
+    - ubuntu-latest
     steps:
-    - uses: actions/checkout@v4.3.0
+    - uses: actions/checkout@v4.2.2
     - uses: DavidAnson/markdownlint-cli2-action@v20.0.0
       with:
-        globs: '**/*.md'
+        globs: '**/*.md'

.gitea/workflows/release.yaml

@@ -1,4 +1,4 @@
-name: "Release"
+name: Release
 
 on:
   push:
@@ -9,15 +9,15 @@ permissions:
 
 jobs:
   release:
-    name: "Release application"
+    runs-on:
-    runs-on: ubuntu-latest
+    - ubuntu-latest
     steps:
-    - uses: actions/checkout@v4.3.0
+    - uses: actions/checkout@v4.2.2
     - uses: docker/setup-qemu-action@v3.6.0
     - uses: actions/setup-go@v5.5.0
       with:
         go-version: stable
-    - uses: docker/login-action@v3.5.0
+    - uses: docker/login-action@v3.4.0
       with:
         registry: git.cryptic.systems
         username: ${{ github.repository_owner }}
@@ -26,13 +26,12 @@ jobs:
         GITEA_TOKEN: ${{ secrets.GIT_CRYPTIC_SYSTEMS_PACKAGE_REGISTRY_TOKEN }}
         GONOSUMDB: ${{ vars.GONOSUMDB }}
         GOPROXY: ${{ vars.GOPROXY }}
-      uses: goreleaser/goreleaser-action@v6.4.0
+      uses: goreleaser/goreleaser-action@v6.3.0
       with:
-        version: v2.11.2 # renovate: datasource=github-releases depName=goreleaser/goreleaser
+        version: "~> v2"
         args: release --clean
 
   sync-to-hub-docker-io:
-    name: "Upload Images to docker.io"
     needs:
     - release
     runs-on: ubuntu-latest

.gitea/workflows/update-docker-hub-description.yaml

@@ -11,7 +11,7 @@ jobs:
     runs-on:
     - ubuntu-latest
     steps:
-    - uses: actions/checkout@v4.3.0
+    - uses: actions/checkout@v4.2.2
     - uses: peter-evans/dockerhub-description@v4.0.2
       with:
         username: ${{ secrets.DOCKER_IO_USERNAME }}

.golangci.yaml

@@ -1,13 +0,0 @@
-version: "2"
-linters:
-  default: standard
-  enable:
-  - errname
-  - gosec
-
-  exclusions:
-    rules: []
-    warn-unused: true
-
-run:
-  tests: true

.golangci.yml

@@ -0,0 +1,28 @@
+issues:
+  exclude-dirs:
+  - it
+
+run:
+  timeout: 10m
+  tests: true
+
+linters:
+  disable-all: true
+  enable:
+  # Default
+  - errcheck
+  - gosimple
+  - govet
+  - ineffassign
+  - staticcheck
+  - typecheck
+  - unused
+
+  # Additionally linters
+  - bodyclose
+  - misspell
+  - nilerr
+  - rowserrcheck
+  - sqlclosecheck
+  - unparam
+  - whitespace

.markdownlint.yaml

@@ -1,136 +0,0 @@
-# markdownlint YAML configuration
-# https://github.com/DavidAnson/markdownlint/blob/main/schema/.markdownlint.yaml
-
-# Default state for all rules
-default: true
-
-# Path to configuration file to extend
-extends: null
-
-# MD003/heading-style/header-style - Heading style
-MD003:
-  # Heading style
-  style: "atx"
-
-# MD004/ul-style - Unordered list style
-MD004:
-  style: "dash"
-
-# MD007/ul-indent - Unordered list indentation
-MD007:
-  # Spaces for indent
-  indent: 2
-  # Whether to indent the first level of the list
-  start_indented: false
-
-# MD009/no-trailing-spaces - Trailing spaces
-MD009:
-  # Spaces for line break
-  br_spaces: 2
-  # Allow spaces for empty lines in list items
-  list_item_empty_lines: false
-  # Include unnecessary breaks
-  strict: false
-
-# MD010/no-hard-tabs - Hard tabs
-MD010:
-  # Include code blocks
-  code_blocks: true
-
-# MD012/no-multiple-blanks - Multiple consecutive blank lines
-MD012:
-  # Consecutive blank lines
-  maximum: 1
-
-# MD013/line-length - Line length
-MD013:
-  # Number of characters
-  line_length: 120
-  # Number of characters for headings
-  heading_line_length: 120
-  # Number of characters for code blocks
-  code_block_line_length: 120
-  # Include code blocks
-  code_blocks: false
-  # Include tables
-  tables: false
-  # Include headings
-  headings: true
-  # Strict length checking
-  strict: false
-  # Stern length checking
-  stern: false
-
-# MD022/blanks-around-headings/blanks-around-headers - Headings should be surrounded by blank lines
-MD022:
-  # Blank lines above heading
-  lines_above: 1
-  # Blank lines below heading
-  lines_below: 1
-
-# MD025/single-title/single-h1 - Multiple top-level headings in the same document
-MD025:
-  # Heading level
-  level: 1
-  # RegExp for matching title in front matter
-  front_matter_title: "^\\s*title\\s*[:=]"
-
-# MD026/no-trailing-punctuation - Trailing punctuation in heading
-MD026:
-  # Punctuation characters
-  punctuation: ".,;:!。，；：！"
-
-# MD029/ol-prefix - Ordered list item prefix
-MD029:
-  # List style
-  style: "one_or_ordered"
-
-# MD030/list-marker-space - Spaces after list markers
-MD030:
-  # Spaces for single-line unordered list items
-  ul_single: 1
-  # Spaces for single-line ordered list items
-  ol_single: 1
-  # Spaces for multi-line unordered list items
-  ul_multi: 1
-  # Spaces for multi-line ordered list items
-  ol_multi: 1
-
-# MD033/no-inline-html - Inline HTML
-MD033:
-  # Allowed elements
-  allowed_elements: []
-
-# MD035/hr-style - Horizontal rule style
-MD035:
-  # Horizontal rule style
-  style: "---"
-
-# MD036/no-emphasis-as-heading/no-emphasis-as-header - Emphasis used instead of a heading
-MD036:
-  # Punctuation characters
-  punctuation: ".,;:!?。，；：！？"
-
-# MD041/first-line-heading/first-line-h1 - First line in a file should be a top-level heading
-MD041:
-  # Heading level
-  level: 1
-  # RegExp for matching title in front matter
-  front_matter_title: "^\\s*title\\s*[:=]"
-
-# MD044/proper-names - Proper names should have the correct capitalization
-MD044:
-  # List of proper names
-  names: []
-  # Include code blocks
-  code_blocks: false
-
-# MD046/code-block-style - Code block style
-MD046:
-  # Block style
-  style: "fenced"
-
-# MD048/code-fence-style - Code fence style
-MD048:
-  # Code fence syle
-  style: "backtick"

Dockerfile

@@ -1,5 +0,0 @@
-FROM scratch AS build
-
-COPY dyndns-client-* /usr/bin/app
-
-ENTRYPOINT [ "/usr/bin/dyndns-client" ]

Makefile

@@ -1,114 +1,53 @@
-dcmergeEXECUTABLE=dyndns-client
+# VERSION
-VERSION?=$(shell git describe --abbrev=0)+hash.$(shell git rev-parse --short HEAD)
+VERSION ?= $(shell git describe --abbrev=0)+hash.$(shell git rev-parse --short HEAD)
 
-# Destination directory and prefix to place the compiled binaries, documentaions
+DESTDIR ?=
-# and other files.
+PREFIX ?= /usr/local
-DESTDIR?=
+EXECUTABLE := dyndns-client
-PREFIX?=/usr/local
 
-# CONTAINER_RUNTIME
+# BINARIES
-# The CONTAINER_RUNTIME variable will be used to specified the path to a
-# container runtime. This is needed to start and run a container image.
-CONTAINER_RUNTIME?=$(shell which podman)
-
-# DYNDNS_CLIENT_IMAGE_REGISTRY_NAME
-# Defines the name of the new container to be built using several variables.
-DYNDNS_CLIENT_IMAGE_REGISTRY_NAME:=git.cryptic.systems
-DYNDNS_CLIENT_IMAGE_REGISTRY_USER:=volker.raschek
-
-DYNDNS_CLIENT_IMAGE_NAMESPACE?=${DYNDNS_CLIENT_IMAGE_REGISTRY_USER}
-DYNDNS_CLIENT_IMAGE_NAME:=${EXECUTABLE}
-_IMAGE_VERSION?=latest
-DYNDNS_CLIENT_IMAGE_FULLY_QUALIFIED=${DYNDNS_CLIENT_IMAGE_REGISTRY_NAME}/${DYNDNS_CLIENT_IMAGE_NAMESPACE}/${DYNDNS_CLIENT_IMAGE_NAME}:${DYNDNS_CLIENT_IMAGE_VERSION}
-
-# BIN
 # ==============================================================================
-dyndns-client:
+all: ${EXECUTABLE}
+
+${EXECUTABLE}:
 	CGO_ENABLED=0 \
+	GOPRIVATE=$(shell go env GOPRIVATE) \
 	GOPROXY=$(shell go env GOPROXY) \
-		go build -ldflags "-X 'main.version=${VERSION}'" -o ${@} main.go
+		go build -ldflags "-X main.version=${VERSION:v%=%}" -o ${@}
+
+# TEST
+# ==============================================================================
+PHONY+=test/unit
+test/unit: clean ${EXECUTABLE}
+	go test -v ./pkg/...
 
 # CLEAN
 # ==============================================================================
 PHONY+=clean
 clean:
-	rm --force --recursive dyndns-client
+	rm --force ${EXECUTABLE} || true
+	rm --force --recursive bin || true
 
-# TESTS
+# UN/INSTALL
 # ==============================================================================
-PHONY+=test/unit
+PHONY+=install
-test/unit:
+install: ${EXECUTABLE}
-	CGO_ENABLED=0 \
-	GOPROXY=$(shell go env GOPROXY) \
-		go test -v -p 1 -coverprofile=coverage.txt -covermode=count -timeout 1200s ./pkg/...
-
-PHONY+=test/integration
-test/integration:
-	CGO_ENABLED=0 \
-	GOPROXY=$(shell go env GOPROXY) \
-		go test -v -p 1 -count=1 -timeout 1200s ./it/...
-
-PHONY+=test/coverage
-test/coverage: test/unit
-	CGO_ENABLED=0 \
-	GOPROXY=$(shell go env GOPROXY) \
-		go tool cover -html=coverage.txt
-
-# GOLANGCI-LINT
-# ==============================================================================
-PHONY+=golangci-lint
-golangci-lint:
-	golangci-lint run --concurrency=$(shell nproc)
-
-# INSTALL
-# ==============================================================================
-PHONY+=uninstall
-install: dyndns-client
-	install --directory ${DESTDIR}/etc/bash_completion.d
-	./dyndns-client completion bash > ${DESTDIR}/etc/bash_completion.d/${EXECUTABLE}
-
 	install --directory ${DESTDIR}${PREFIX}/bin
-	install --mode 0755 ${EXECUTABLE} ${DESTDIR}${PREFIX}/bin/${EXECUTABLE}
+	install --mode 755 ${EXECUTABLE} ${DESTDIR}${PREFIX}/bin/${EXECUTABLE}
 
-	install --directory ${DESTDIR}${PREFIX}/share/licenses/${EXECUTABLE}
+	install --directory ${DESTDIR}/usr/lib/systemd/system
-	install --mode 0644 LICENSE ${DESTDIR}${PREFIX}/share/licenses/${EXECUTABLE}/LICENSE
+	install --mode 644 systemd/${EXECUTABLE}.service ${DESTDIR}/usr/lib/systemd/system
+
+	install --directory ${DESTDIR}/usr/share/licenses/${EXECUTABLE}
+	install --mode 644 LICENSE ${DESTDIR}/usr/share/licenses/${EXECUTABLE}/LICENSE
 
-# UNINSTALL
-# ==============================================================================
 PHONY+=uninstall
 uninstall:
-	-rm --force --recursive \
+	-rm --recursive --force \
-		${DESTDIR}/etc/bash_completion.d/${EXECUTABLE} \
 		${DESTDIR}${PREFIX}/bin/${EXECUTABLE} \
-		${DESTDIR}${PREFIX}/share/licenses/${EXECUTABLE}
+		${DESTDIR}/usr/lib/systemd/system/${EXECUTABLE}.service \
-
+		${DESTDIR}/usr/share/licenses/${EXECUTABLE}/LICENSE
-# BUILD CONTAINER IMAGE
-# ==============================================================================
-PHONY+=container-image/build
-container-image/build:
-	${CONTAINER_RUNTIME} build \
-		--build-arg VERSION=${VERSION} \
-		--file Dockerfile \
-		--no-cache \
-		--pull \
-		--tag ${DYNDNS_CLIENT_IMAGE_FULLY_QUALIFIED} \
-		.
-
-# DELETE CONTAINER IMAGE
-# ==============================================================================
-PHONY:=container-image/delete
-container-image/delete:
-	- ${CONTAINER_RUNTIME} image rm ${DYNDNS_CLIENT_IMAGE_FULLY_QUALIFIED}
-
-# PUSH CONTAINER IMAGE
-# ==============================================================================
-PHONY+=container-image/push
-container-image/push:
-	echo ${DYNDNS_CLIENT_IMAGE_REGISTRY_PASSWORD} | ${CONTAINER_RUNTIME} login ${DYNDNS_CLIENT_IMAGE_REGISTRY_NAME} --username ${DYNDNS_CLIENT_IMAGE_REGISTRY_USER} --password-stdin
-	${CONTAINER_RUNTIME} push ${DYNDNS_CLIENT_IMAGE_FULLY_QUALIFIED}
 
 # PHONY
 # ==============================================================================
-# Declare the contents of the PHONY variable as phony.  We keep that information
+.PHONY: ${PHONY}
-# in a variable so we can use it in if_changed.
-.PHONY: ${PHONY}

go.mod

@@ -3,7 +3,7 @@ module git.cryptic.systems/volker.raschek/dyndns-client
 go 1.20
 
 require (
-	github.com/asaskevich/govalidator v0.0.0-20230301143203-a9d515a09cc2
+	github.com/asaskevich/govalidator/v11 v11.0.1
 	github.com/sirupsen/logrus v1.9.3
 	github.com/vishvananda/netlink v1.3.1
 )

pkg/config/config.go

@@ -152,7 +152,7 @@ func getOutboundIP() net.IP {
 	if err != nil {
 		log.Fatal(err)
 	}
-	defer func() { _ = conn.Close() }()
+	defer conn.Close()
 	localAddr := conn.LocalAddr().(*net.UDPAddr)
 	return localAddr.IP
 }