From 7f868a0a274328fb0852be0ec120c63d965591fd Mon Sep 17 00:00:00 2001
From: Markus Pesch <markus.pesch@cryptic.systems>
Date: Thu, 3 Apr 2025 17:52:36 +0000
Subject: [PATCH] chore(ci): add shellcheck (#7)

Reviewed-on: https://gitea.com/gitea/helm-actions/pulls/7
Reviewed-by: justusbunsi <justusbunsi@noreply.gitea.com>
Co-authored-by: Markus Pesch <markus.pesch@cryptic.systems>
Co-committed-by: Markus Pesch <markus.pesch@cryptic.systems>
---
 .editorconfig                   |  5 ++++-
 .gitea/workflows/shellcheck.yml | 14 ++++++++++++++
 Makefile                        |  5 ++++-
 scripts/token.sh                | 11 ++++++++---
 4 files changed, 30 insertions(+), 5 deletions(-)
 create mode 100644 .gitea/workflows/shellcheck.yml

diff --git a/.editorconfig b/.editorconfig
index ebe51d3..e560cbb 100644
--- a/.editorconfig
+++ b/.editorconfig
@@ -9,4 +9,7 @@ indent_size = 2
 end_of_line = lf
 charset = utf-8
 trim_trailing_whitespace = false
-insert_final_newline = false
\ No newline at end of file
+insert_final_newline = false
+
+[Makefile]
+indent_style = tab
\ No newline at end of file
diff --git a/.gitea/workflows/shellcheck.yml b/.gitea/workflows/shellcheck.yml
new file mode 100644
index 0000000..592c555
--- /dev/null
+++ b/.gitea/workflows/shellcheck.yml
@@ -0,0 +1,14 @@
+name: Lint Shell files
+
+on:
+  pull_request:
+    branches: ["*"]
+    types: ["opened", "reopened", "synchronize"]
+
+jobs:
+  shellcheck:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4.2.2
+      - run: apt update --yes && apt install --yes shellcheck
+      - run: find . -type f -name "*.sh" -exec shellcheck -a {} \;
diff --git a/Makefile b/Makefile
index 9346d0e..24aba16 100644
--- a/Makefile
+++ b/Makefile
@@ -16,4 +16,7 @@ unittests-helm:
 .PHONY: helm
 update-helm-dependencies:
 	helm dependency update
-  
\ No newline at end of file
+
+.PHONY: yamllint
+yamllint:
+	yamllint -c .yamllint .
\ No newline at end of file
diff --git a/scripts/token.sh b/scripts/token.sh
index cbb2ebd..ac4fd37 100755
--- a/scripts/token.sh
+++ b/scripts/token.sh
@@ -8,9 +8,14 @@ check_token() {
   set +e
 
   echo "Checking for existing token..."
-  token="$(kubectl get secret "$SECRET_NAME" -o jsonpath="{.data['token']}" 2> /dev/null)"
-  [ $? -ne 0 ] && return 1
-  [ -z "$token" ] && return 2
+  if ! token=$(kubectl get secret "${SECRET_NAME}" -o jsonpath="{.data['token']}" 2> /dev/null); then
+    return 1
+  fi
+
+  if [ -z "${token}" ]; then
+    return 2
+  fi
+
   return 0
 }