fix(scripts): shellcheck: SC2181

.gitea/workflows/shellcheck.yml

@@ -6,10 +6,6 @@ on:
     types: [ "opened", "edited" ]
   workflow_dispatch: {}
 
-env:
-  # renovate: datasource=docker depName=koalaman/shellcheck
-  HELM_VERSION: "v0.10.0"
-
 jobs:
   shellcheck:
     runs-on: ubuntu-latest

scripts/token.sh

@@ -8,9 +8,14 @@ check_token() {
   set +e
 
   echo "Checking for existing token..."
-  token="$(kubectl get secret "$SECRET_NAME" -o jsonpath="{.data['token']}" 2> /dev/null)"
-  [ $? -ne 0 ] && return 1
-  [ -z "$token" ] && return 2
+  if ! token=$(kubectl get secret "${SECRET_NAME}" -o jsonpath="{.data['token']}" 2> /dev/null); then
+    return 1
+  fi
+
+  if [ -z "${token}" ]; then
+    return 2
+  fi
+
   return 0
 }