chore(ci): add shellcheck

.editorconfig

@@ -9,7 +9,4 @@ indent_size = 2
 end_of_line = lf
 charset = utf-8
 trim_trailing_whitespace = false
-insert_final_newline = false
+insert_final_newline = false
-
-[Makefile]
-indent_style = tab

.gitea/workflows/shellcheck.yml

@@ -2,13 +2,18 @@ name: Lint Shell files
 
 on:
   pull_request:
-    branches: ["*"]
+    branches: [ "*" ]
-    types: ["opened", "reopened", "synchronize"]
+    types: [ "opened", "edited" ]
+  workflow_dispatch: {}
+
+env:
+  # renovate: datasource=docker depName=koalaman/shellcheck
+  HELM_VERSION: "v0.10.0"
 
 jobs:
   shellcheck:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v4.2.2
+    - uses: actions/checkout@v4.2.2
-      - run: apt update --yes && apt install --yes shellcheck
+    - run: apt install shellcheck
-      - run: find . -type f -name "*.sh" -exec shellcheck -a {} \;
+    - run: find . -type f -name "*.sh" -exec shellcheck -a {} \;

Makefile

@@ -16,7 +16,4 @@ unittests-helm:
 .PHONY: helm
 update-helm-dependencies:
 	helm dependency update
-
+  
-.PHONY: yamllint
-yamllint:
-	yamllint -c .yamllint .

scripts/token.sh

@@ -8,14 +8,9 @@ check_token() {
   set +e
 
   echo "Checking for existing token..."
-  if ! token=$(kubectl get secret "${SECRET_NAME}" -o jsonpath="{.data['token']}" 2> /dev/null); then
+  token="$(kubectl get secret "$SECRET_NAME" -o jsonpath="{.data['token']}" 2> /dev/null)"
-    return 1
+  [ $? -ne 0 ] && return 1
-  fi
+  [ -z "$token" ] && return 2
-
-  if [ -z "${token}" ]; then
-    return 2
-  fi
-
   return 0
 }