chore(ci): add shellcheck

.editorconfig

@@ -10,6 +10,3 @@ end_of_line = lf
 charset = utf-8
 trim_trailing_whitespace = false
 insert_final_newline = false
-
-[Makefile]
-indent_style = tab

.gitea/workflows/shellcheck.yml

@@ -3,12 +3,17 @@ name: Lint Shell files
 on:
   pull_request:
     branches: [ "*" ]
-    types: ["opened", "reopened", "synchronize"]
+    types: [ "opened", "edited" ]
+  workflow_dispatch: {}
+
+env:
+  # renovate: datasource=docker depName=koalaman/shellcheck
+  HELM_VERSION: "v0.10.0"
 
 jobs:
   shellcheck:
     runs-on: ubuntu-latest
     steps:
     - uses: actions/checkout@v4.2.2
-      - run: apt update --yes && apt install --yes shellcheck
+    - run: apt install shellcheck
     - run: find . -type f -name "*.sh" -exec shellcheck -a {} \;

Makefile

@@ -17,6 +17,3 @@ unittests-helm:
 update-helm-dependencies:
 	helm dependency update
   
-.PHONY: yamllint
-yamllint:
-	yamllint -c .yamllint .

scripts/token.sh

@@ -8,14 +8,9 @@ check_token() {
   set +e
 
   echo "Checking for existing token..."
-  if ! token=$(kubectl get secret "${SECRET_NAME}" -o jsonpath="{.data['token']}" 2> /dev/null); then
-    return 1
-  fi
-
-  if [ -z "${token}" ]; then
-    return 2
-  fi
-
+  token="$(kubectl get secret "$SECRET_NAME" -o jsonpath="{.data['token']}" 2> /dev/null)"
+  [ $? -ne 0 ] && return 1
+  [ -z "$token" ] && return 2
   return 0
 }