feat!: remove the helm test connection Pod
Bash / bash-unittest (push) Successful in 18s
changelog / changelog (push) Successful in 21s
Helm / helm-lint (push) Successful in 9s
Markdown linter / markdown-lint (push) Successful in 14s
Helm / helm-unittest (push) Successful in 1m11s
Markdown linter / markdown-link-checker (push) Successful in 43s
Bash / bash-unittest (push) Successful in 18s
changelog / changelog (push) Successful in 21s
Helm / helm-lint (push) Successful in 9s
Markdown linter / markdown-lint (push) Successful in 14s
Helm / helm-unittest (push) Successful in 1m11s
Markdown linter / markdown-link-checker (push) Successful in 43s
The chart shipped a `helm test` hook Pod that ran `wget` against the HTTP Service. It only proved that the Service resolves and answers on the configured port, which the readiness probe already covers, so it carried no information the release did not have anyway. In exchange it pulled `busybox:latest` into clusters -- an unpinned, mutable tag in a chart that otherwise pins every image digest -- and it kept a Pod spec alive that had to track every change to the security context and hostUsers helpers. Removing the template also removes the `test.*` values that only existed to configure it, so the parameter table in the README was regenerated accordingly. A guard in `deprecation.yaml` catches leftover `test` values instead of silently ignoring them. Its message deviates from the surrounding guards on purpose: there is no replacement value to point at, so it states that the feature is gone rather than suggesting a migration target. BREAKING CHANGE: `helm test <release>` no longer executes any test for this chart, and the values `test.enabled`, `test.image.name` and `test.image.tag` have been removed. Installations that still set them will fail with a descriptive error until the keys are dropped, unless `checkDeprecation` is set to false. Co-authored-by: Copilot <copilot@github.com>
This commit is contained in:
@@ -125,6 +125,11 @@
|
||||
{{- fail "`strategy` does no longer exist. Please refer to the changelog and configure `deployment.strategy` instead." -}}
|
||||
{{- end -}}
|
||||
|
||||
{{/* TEST */}}
|
||||
{{- if .Values.test -}}
|
||||
{{- fail "`test` does no longer exist. Please refer to the changelog. The `helm test` connection Pod has been removed without replacement." -}}
|
||||
{{- end -}}
|
||||
|
||||
{{/* TOLERATIONS */}}
|
||||
{{- if .Values.tolerations -}}
|
||||
{{- fail "`tolerations` does no longer exist. Please refer to the changelog and configure `deployment.tolerations` instead." -}}
|
||||
|
||||
@@ -1,27 +0,0 @@
|
||||
{{- if .Values.test.enabled }}
|
||||
apiVersion: v1
|
||||
kind: Pod
|
||||
metadata:
|
||||
name: "{{ include "gitea.fullname" . }}-test-connection"
|
||||
namespace: {{ .Values.namespace | default .Release.Namespace }}
|
||||
labels:
|
||||
{{ include "gitea.labels" . | nindent 4 }}
|
||||
annotations:
|
||||
"helm.sh/hook": test-success
|
||||
spec:
|
||||
{{- $hostUsers := include "gitea.hostUsers" . | trim }}
|
||||
{{- $testContainerSecurityContext := include "gitea.containerSecurityContext" (list . (dict)) | trim }}
|
||||
{{- if $hostUsers }}
|
||||
hostUsers: {{ $hostUsers }}
|
||||
{{- end }}
|
||||
containers:
|
||||
- name: wget
|
||||
image: "{{ .Values.test.image.name }}:{{ .Values.test.image.tag }}"
|
||||
{{- if $testContainerSecurityContext }}
|
||||
securityContext:
|
||||
{{- $testContainerSecurityContext | nindent 8 }}
|
||||
{{- end }}
|
||||
command: ['wget']
|
||||
args: ['{{ include "gitea.service.http.name" . }}:{{ .Values.service.http.port }}']
|
||||
restartPolicy: Never
|
||||
{{- end }}
|
||||
Reference in New Issue
Block a user