refactor(persistence)!: group the values into existingPersistentVolumeClaim and new
The flat `persistence` dict mixed three concerns: whether persistence is used at all, whether the chart creates the PersistentVolumeClaim, and how that claim is shaped. The pairs `create`/`claimName` and `enabled`/`mount` were only meaningful in certain combinations, so an invalid configuration such as `create=true` together with a foreign `claimName` was silently accepted. The same split into an `existingX`/`new` pair is already used for the Secrets, so this aligns persistence with the rest of the chart. `persistence.enabled` now only decides whether a volume is used at all. `persistence.existingPersistentVolumeClaim` points at a claim managed outside of the chart, and everything under `persistence.new` describes the claim the chart creates itself. Rendering and naming move into `templates/gitea/_persistentVolumeClaims.tpl` so the Deployment and the PersistentVolumeClaim derive the claim name from a single helper instead of repeating the value lookups. Support for `global.storageClass` is dropped. It was a chart-wide override that silently applied to the Gitea claim and was evaluated through `tpl`, which made the effective storage class hard to predict. The storage class is now set explicitly via `persistence.new.storageClassName`, which also matches the field name in the PersistentVolumeClaim spec. BREAKING CHANGE: The `persistence` values were restructured and `global.storageClass` was removed. - `persistence.create` and `persistence.mount` are gone. Set `persistence.enabled` to use a volume and `persistence.existingPersistentVolumeClaim.enabled` to reuse a claim that is not managed by the chart. - `persistence.claimName` moves to `persistence.existingPersistentVolumeClaim.persistentVolumeClaimName`. A claim created by the chart is now named after `gitea.fullname` instead of the default `gitea-shared-storage`. - `persistence.accessModes`, `annotations`, `labels`, `size` and `subPath` move into `persistence.new`. - `persistence.volumeName` becomes `persistence.new.persistentVolumeName`. - `persistence.storageClass` and `global.storageClass` become `persistence.new.storageClassName`. - `persistence.enabled` now defaults to `false`. Co-authored-by: Copilot <copilot@github.com>
This commit is contained in:
Copilot
@@ -1023,7 +1023,6 @@ To comply with the Gitea helm chart definition of the digest parameter, a "custo
|
||||
| ------------------------- | -------------------------------------------------------------------------- | ----- |
|
||||
| `global.imageRegistry` | global image registry override. | `""` |
|
||||
| `global.imagePullSecrets` | global image pull secrets override; can be extended by `imagePullSecrets`. | `[]` |
|
||||
| `global.storageClass` | global storage class override. | `""` |
|
||||
| `global.hostAliases` | global hostAliases which will be added to the pod's hosts files. | `[]` |
|
||||
|
||||
### deployment
|
||||
@@ -1287,22 +1286,21 @@ To comply with the Gitea helm chart definition of the digest parameter, a "custo
|
||||
|
||||
### Persistence
|
||||
|
||||
| Name | Description | Value |
|
||||
| ------------------------------------------------- | -------------------------------------------------------------------------------------------------- | ---------------------- |
|
||||
| `persistence.enabled` | Enable persistent storage. | `true` |
|
||||
| `persistence.create` | Whether to create the persistentVolumeClaim for shared storage. | `true` |
|
||||
| `persistence.mount` | Whether the persistentVolumeClaim should be mounted (even if not created). | `true` |
|
||||
| `persistence.claimName` | Use an existing claim to store repository information. | `gitea-shared-storage` |
|
||||
| `persistence.size` | Size for persistence to store repo information. | `10Gi` |
|
||||
| `persistence.accessModes` | AccessMode for persistence. | `["ReadWriteOnce"]` |
|
||||
| `persistence.labels` | Labels for the persistence volume claim to be created. | `{}` |
|
||||
| `persistence.annotations.helm.sh/resource-policy` | Resource policy for the persistence volume claim. | `keep` |
|
||||
| `persistence.storageClass` | Name of the storage class to use. | `nil` |
|
||||
| `persistence.subPath` | Subdirectory of the volume to mount at. | `nil` |
|
||||
| `persistence.volumeName` | Name of persistent volume in PVC. | `""` |
|
||||
| `extraContainers` | Additional sidecar containers to run in the pod. | `[]` |
|
||||
| `extraInitVolumeMounts` | Mounts that are only mapped into the init-containers. Can be used for additional preconfiguration. | `[]` |
|
||||
| `extraVolumeMounts` | **DEPRECATED** Additional volume mounts for init containers and the Gitea main container. | `[]` |
|
||||
| Name | Description | Value |
|
||||
| --------------------------------------------------------------------- | -------------------------------------------------------------------------------------------------- | ------------------- |
|
||||
| `persistence.enabled` | Enable persistent storage. | `false` |
|
||||
| `persistence.existingPersistentVolumeClaim.enabled` | Enable using an existing persistent volume claim. | `false` |
|
||||
| `persistence.existingPersistentVolumeClaim.persistentVolumeClaimName` | Name of the existing persistent volume claim to use. | `""` |
|
||||
| `persistence.new.annotations.helm.sh/resource-policy` | Resource policy for the new persistent volume claim. | `keep` |
|
||||
| `persistence.new.labels` | Labels for the new persistent volume claim. | `{}` |
|
||||
| `persistence.new.accessModes` | AccessMode for the new persistent volume claim. | `["ReadWriteOnce"]` |
|
||||
| `persistence.new.persistentVolumeName` | Name of the persistent volume for the new persistent volume claim. | `""` |
|
||||
| `persistence.new.size` | Size for the new persistent volume claim. | `10Gi` |
|
||||
| `persistence.new.storageClassName` | Name of the storage class to use for the new persistent volume claim. | `""` |
|
||||
| `persistence.new.subPath` | Subdirectory of the volume to mount at for the new persistent volume claim. | `""` |
|
||||
| `extraContainers` | Additional sidecar containers to run in the pod. | `[]` |
|
||||
| `extraInitVolumeMounts` | Mounts that are only mapped into the init-containers. Can be used for additional preconfiguration. | `[]` |
|
||||
| `extraVolumeMounts` | **DEPRECATED** Additional volume mounts for init containers and the Gitea main container. | `[]` |
|
||||
|
||||
### Init
|
||||
|
||||
|
||||
Reference in New Issue
Block a user