feat(deployment)!: configurable init containers and Secret checksum lookup

The chart-managed init containers were hardcoded inside `deployment.yaml`. Their image, environment, resources,
security context and volume mounts could not be adjusted individually, and custom init containers could only be
prepended or appended as a whole via `preExtraInitContainers`/`postExtraInitContainers`.

The init containers are now rendered from `deployment.initContainers`, an ordered list whose entries either `link` a
chart-managed init container (`initDirectories`, `initAppIni`, `initConfigureGPG`, `initConfigureGitea`) or provide a
free-form `container` definition. This allows custom containers at any position and makes the execution order
explicit. Each linked init container has its own configuration block in `values.yaml` and falls back to
`deployment.gitea.securityContext` and `initContainers.resources` when unset.

To support per-container images, `gitea.image` was split into the generic helper `gitea.image.name`, which renders an
arbitrary `image` dict instead of only `deployment.gitea.image`.

The pod annotations moved from `deployment.yaml` into the new helper `gitea.pod.annotations`. The SHA sum annotations
now also cover user-provided Secrets: their content is unknown to the chart, so the Secret is read from the cluster via
Helm's `lookup` function. Chart-managed Secrets keep using the rendered manifest, because the cluster still holds their
pre-upgrade state during rendering.

Because `lookup` requires `get` permission on Secrets and silently returns nothing during client-side rendering
(`helm template`, `--dry-run`, Argo CD without a live cluster), `addSHASumAnnotation` now defaults to `false`. The
trade-offs are documented in the README so users can make an informed decision.

BREAKING CHANGE: `preExtraInitContainers` and `postExtraInitContainers` have been removed. Add an entry with a
`container` key before or after the linked init containers in `deployment.initContainers` instead.

BREAKING CHANGE: `secrets.<secret>.addSHASumAnnotation` now defaults to `false`. Set it to `true` explicitly to keep
the rollout trigger on Secret changes.

Co-authored-by: Copilot <copilot@github.com>
This commit is contained in:
2026-09-13 19:11:28 +02:00
co-authored by Copilot
parent c409e201b3
commit e8f3a058ce
15 changed files with 1267 additions and 444 deletions
@@ -0,0 +1,130 @@
suite: deployment template (init container configuration)
release:
name: gitea-unittests
namespace: testing
templates:
- templates/gitea/deployment.yaml
- templates/gitea/secret_admin.yaml
- templates/gitea/secret_config.yaml
- templates/gitea/secret_gpg.yaml
- templates/gitea/secret_init.yaml
- templates/gitea/secret_inlineConfig.yaml
- templates/gitea/secret_metrics.yaml
tests:
- it: appends the per-container env
template: templates/gitea/deployment.yaml
set:
deployment.initDirectories.env:
- name: INIT_DIRECTORIES
value: "1"
deployment.gitea.env:
- name: SHARED
value: "1"
asserts:
- contains:
path: spec.template.spec.initContainers[0].env
content:
name: INIT_DIRECTORIES
value: "1"
- contains:
path: spec.template.spec.initContainers[0].env
content:
name: SHARED
value: "1"
- notContains:
path: spec.template.spec.initContainers[1].env
content:
name: INIT_DIRECTORIES
value: "1"
- it: renders the per-container envFrom
template: templates/gitea/deployment.yaml
set:
deployment.initAppIni.envFrom:
- secretRef:
name: special-secret
asserts:
- notExists:
path: spec.template.spec.initContainers[0].envFrom
- equal:
path: spec.template.spec.initContainers[1].envFrom
value:
- secretRef:
name: special-secret
- it: appends the per-container volumeMounts
template: templates/gitea/deployment.yaml
set:
deployment.initConfigureGitea.volumeMounts:
- name: my-configmap-volume
mountPath: /configmap
readOnly: true
asserts:
- contains:
path: spec.template.spec.initContainers[2].volumeMounts
content:
name: my-configmap-volume
mountPath: /configmap
readOnly: true
- notContains:
path: spec.template.spec.initContainers[0].volumeMounts
content:
name: my-configmap-volume
mountPath: /configmap
readOnly: true
- it: overrides the resources of a single init container
template: templates/gitea/deployment.yaml
set:
deployment.initDirectories.resources:
requests:
cpu: 500m
asserts:
- equal:
path: spec.template.spec.initContainers[0].resources
value:
requests:
cpu: 500m
- equal:
path: spec.template.spec.initContainers[1].resources
value:
limits: {}
requests:
cpu: 100m
memory: 128Mi
- it: overrides the security context of a single init container
template: templates/gitea/deployment.yaml
set:
deployment.gitea.securityContext:
runAsUser: 1000
deployment.initDirectories.securityContext:
runAsUser: 2000
asserts:
- equal:
path: spec.template.spec.initContainers[0].securityContext.runAsUser
value: 2000
- equal:
path: spec.template.spec.initContainers[1].securityContext.runAsUser
value: 1000
- it: renders the envFrom of the gitea container
template: templates/gitea/deployment.yaml
set:
deployment.gitea.envFrom:
- configMapRef:
name: special-config
asserts:
- equal:
path: spec.template.spec.containers[0].envFrom
value:
- configMapRef:
name: special-config
- it: omits envFrom when unset
template: templates/gitea/deployment.yaml
asserts:
- notExists:
path: spec.template.spec.containers[0].envFrom
- notExists:
path: spec.template.spec.initContainers[0].envFrom