3 Commits

Include renames

Author	SHA1	Message	Date
volker.raschekandCopilot	bb3b59f1ee	test: normalize the titles of the helm unit tests ... The contributor guidelines require that the title of a unit test is "a short sentence starting with a capital letter and ending without a period". Only 30 of the 269 titles followed that rule. The remaining ones were lowercase verb phrases ("renders a deployment"), which made the test output read inconsistently depending on which suite was running, and made it impossible to tell a convention violation from an intentional style. All titles are now imperative, capitalized and unquoted-safe: renders a deployment -> Render a Deployment should not render when gatewayAPI.enabled is false -> Skip rendering when gatewayAPI.enabled is false skips gpg volume spec -> Skip the gpg volume spec The bracketed prefixes of the dependency checks and of the server section suite are kept, because they group the tests by the chart they assert on. Only the sentence behind the prefix was rewritten. Beyond the pure capitalization three classes of titles needed real rewording: - The titles in image-configuration.yaml named a subject instead of a scenario ("default values", "tag override", "digest and global registry"). They now describe what is rendered. - init_directory_structure.sh-rootless.yaml carried "it does not chown /data ...", which rendered as "it it does not chown" in the test output. - The "should" prefix in the Gateway API and route suites added no information once the title is a sentence. The title of the GIT_GC_REPOS test lost its embedded double quotes. The title was previously an unquoted YAML scalar, so the quotes were literal characters; quoting the title turned them into a parse error. The value is unambiguous without them. Three byte-identical tests asserting pgpool.adminPassword existed in customization-integrity-postgresql-ha.yaml - same template, same assertion, same expected value. They were a copy-paste artifact and shared one title, so two of them are removed. No coverage is lost, which is why the test count drops from 269 to 267. No snapshot files are tracked and no suite uses matchSnapshot, so retitling cannot invalidate stored snapshots. Co-authored-by: Copilot <copilot@github.com>	2026-10-03 21:17:18 +02:00
volker.raschekandCopilot	552fe8c56e	refactor(templates): move the templates out of the gitea subdirectory ... The `templates/gitea` subdirectory did not group anything meaningful, since every template of this chart belongs to Gitea. It only duplicated the chart name in every path and forced the unit tests to spell out `templates/gitea/<name>.yaml`, while `_helpers.tpl` and `NOTES.txt` already lived directly in `templates`. All templates now live in `templates`, which matches the layout of the bundled sub-charts and the Helm defaults. The checksum helper in `templates/_secrets.tpl` built its include path from `$root.Template.BasePath` and therefore carried the subdirectory in a `printf` format string instead of a literal path. Without adjusting it the chart failed to render with "no template gitea/templates/gitea/secret_config.yaml associated with template gotpl". Co-authored-by: Copilot <copilot@github.com>	2026-09-14 20:28:17 +02:00
volker.raschekandCopilot	e8f3a058ce	feat(deployment)!: configurable init containers and Secret checksum lookup ... The chart-managed init containers were hardcoded inside `deployment.yaml`. Their image, environment, resources, security context and volume mounts could not be adjusted individually, and custom init containers could only be prepended or appended as a whole via `preExtraInitContainers`/`postExtraInitContainers`. The init containers are now rendered from `deployment.initContainers`, an ordered list whose entries either `link` a chart-managed init container (`initDirectories`, `initAppIni`, `initConfigureGPG`, `initConfigureGitea`) or provide a free-form `container` definition. This allows custom containers at any position and makes the execution order explicit. Each linked init container has its own configuration block in `values.yaml` and falls back to `deployment.gitea.securityContext` and `initContainers.resources` when unset. To support per-container images, `gitea.image` was split into the generic helper `gitea.image.name`, which renders an arbitrary `image` dict instead of only `deployment.gitea.image`. The pod annotations moved from `deployment.yaml` into the new helper `gitea.pod.annotations`. The SHA sum annotations now also cover user-provided Secrets: their content is unknown to the chart, so the Secret is read from the cluster via Helm's `lookup` function. Chart-managed Secrets keep using the rendered manifest, because the cluster still holds their pre-upgrade state during rendering. Because `lookup` requires `get` permission on Secrets and silently returns nothing during client-side rendering (`helm template`, `--dry-run`, Argo CD without a live cluster), `addSHASumAnnotation` now defaults to `false`. The trade-offs are documented in the README so users can make an informed decision. BREAKING CHANGE: `preExtraInitContainers` and `postExtraInitContainers` have been removed. Add an entry with a `container` key before or after the linked init containers in `deployment.initContainers` instead. BREAKING CHANGE: `secrets.<secret>.addSHASumAnnotation` now defaults to `false`. Set it to `true` explicitly to keep the rollout trigger on Secret changes. Co-authored-by: Copilot <copilot@github.com>	2026-09-13 19:11:28 +02:00