5 Commits

Include renames

Author	SHA1	Message	Date
volker.raschekandCopilot	bb3b59f1ee	test: normalize the titles of the helm unit tests ... The contributor guidelines require that the title of a unit test is "a short sentence starting with a capital letter and ending without a period". Only 30 of the 269 titles followed that rule. The remaining ones were lowercase verb phrases ("renders a deployment"), which made the test output read inconsistently depending on which suite was running, and made it impossible to tell a convention violation from an intentional style. All titles are now imperative, capitalized and unquoted-safe: renders a deployment -> Render a Deployment should not render when gatewayAPI.enabled is false -> Skip rendering when gatewayAPI.enabled is false skips gpg volume spec -> Skip the gpg volume spec The bracketed prefixes of the dependency checks and of the server section suite are kept, because they group the tests by the chart they assert on. Only the sentence behind the prefix was rewritten. Beyond the pure capitalization three classes of titles needed real rewording: - The titles in image-configuration.yaml named a subject instead of a scenario ("default values", "tag override", "digest and global registry"). They now describe what is rendered. - init_directory_structure.sh-rootless.yaml carried "it does not chown /data ...", which rendered as "it it does not chown" in the test output. - The "should" prefix in the Gateway API and route suites added no information once the title is a sentence. The title of the GIT_GC_REPOS test lost its embedded double quotes. The title was previously an unquoted YAML scalar, so the quotes were literal characters; quoting the title turned them into a parse error. The value is unambiguous without them. Three byte-identical tests asserting pgpool.adminPassword existed in customization-integrity-postgresql-ha.yaml - same template, same assertion, same expected value. They were a copy-paste artifact and shared one title, so two of them are removed. No coverage is lost, which is why the test count drops from 269 to 267. No snapshot files are tracked and no suite uses matchSnapshot, so retitling cannot invalidate stored snapshots. Co-authored-by: Copilot <copilot@github.com>	2026-10-03 21:17:18 +02:00
volker.raschekandCopilot	552fe8c56e	refactor(templates): move the templates out of the gitea subdirectory ... The `templates/gitea` subdirectory did not group anything meaningful, since every template of this chart belongs to Gitea. It only duplicated the chart name in every path and forced the unit tests to spell out `templates/gitea/<name>.yaml`, while `_helpers.tpl` and `NOTES.txt` already lived directly in `templates`. All templates now live in `templates`, which matches the layout of the bundled sub-charts and the Helm defaults. The checksum helper in `templates/_secrets.tpl` built its include path from `$root.Template.BasePath` and therefore carried the subdirectory in a `printf` format string instead of a literal path. Without adjusting it the chart failed to render with "no template gitea/templates/gitea/secret_config.yaml associated with template gotpl". Co-authored-by: Copilot <copilot@github.com>	2026-09-14 20:28:17 +02:00
volker.raschekandCopilot	a4c6893874	refactor(templates)!: centralize Secret names in gitea.secret.*.name helpers ... The names of the Secrets rendered by the chart were built inline in each template and, for two of them, in ad-hoc chart-wide helpers. The same name therefore existed in several places (Deployment volumes, ServiceMonitor credentials, the Secret templates themselves), which made every rename a multi-file change and allowed the references to drift apart unnoticed - the Helm unit tests render one template at a time and cannot detect a mismatching secretName. All Secret names are now defined once in templates/gitea/_secrets.tpl: gitea.secret.config.name -> <fullname>-config gitea.secret.gpg.name -> <fullname>-gpg-key (or signing.existingSecret) gitea.secret.init.name -> <fullname>-init gitea.secret.inlineConfig.name -> <fullname>-inline-config gitea.secret.metrics.name -> <fullname>-metrics gitea.gpg-key-secret-name and gitea.metrics-secret-name are removed from _helpers.tpl accordingly. A checksum/inlineConfig pod annotation is added as well. After the inline configuration had been split out of secret_config.yaml, changes to it were no longer covered by any checksum annotation and did not trigger a rollout of the Deployment. Finally the metadata attributes of the Secret templates are sorted alphabetically as required by the chart conventions. BREAKING CHANGE: two Secrets are renamed. The config Secret changes from <fullname> to <fullname>-config and the metrics Secret from <fullname>-metrics-secret to <fullname>-metrics. Helm replaces both on upgrade; references to them from outside the chart have to be adjusted. Co-authored-by: Copilot <copilot@github.com>	2026-09-03 15:32:03 +02:00
volker.raschekandCopilot	4884dc0fe0	refactor(templates): rename template files to match rendered resource kinds ... The files in templates/gitea/ used a mix of naming styles: lowercase concatenations (poddisruptionbudget.yaml, serviceaccount.yaml, servicemonitor.yaml, pvc.yaml), camelCase (httpService.yaml, sshService.yaml) and kind-suffixed names (gpg-secret.yaml, metrics-secret.yaml). It was therefore not obvious from a file name which Kubernetes resource it renders, and the naming contradicted the camelCase convention the Gateway API templates already follow. Files are now named after the kind they render, with a lowercase suffix distinguishing several resources of the same kind: config.yaml -> secret_config.yaml + secret_inlineConfig.yaml gpg-secret.yaml -> secret_gpg.yaml init.yaml -> secret_init.yaml metrics-secret.yaml -> secret_metrics.yaml httpService.yaml -> service_http.yaml sshService.yaml -> service_ssh.yaml poddisruptionbudget.yaml -> podDisruptionBudget.yaml pvc.yaml -> persistentVolumeClaim.yaml serviceaccount.yaml -> serviceAccount.yaml servicemonitor.yaml -> serviceMonitor.yaml config.yaml rendered two Secrets from a single file, which forced every unit test to address them via documentIndex. It is split so that each file renders exactly one resource. The rendered manifests are unchanged; only file names and the references to them were touched. This includes the checksum/config annotation in deployment.yaml and all helm unit test suites. The HA guard assertions had to move from deployment.yaml to secret_config.yaml: Helm sorts templates in reverse alphabetical order, so secret_config.yaml is now rendered before deployment.yaml and the fail() is reported for that file directly instead of bubbling up through the include chain of the Deployment. Users relying on the template paths (e.g. `helm template --show-only` or post-renderers) have to adjust to the new file names. Co-authored-by: Copilot <copilot@github.com>	2026-09-03 14:20:12 +02:00
justusbunsi	4691b63f7a	Move Helm unittests into subfolder (#750) ... Reviewed-on: https://gitea.com/gitea/helm-chart/pulls/750 Co-authored-by: justusbunsi <sk.bunsenbrenner@gmail.com> Co-committed-by: justusbunsi <sk.bunsenbrenner@gmail.com>	2024-12-18 12:04:15 +00:00