volker.raschekandCopilot
4884dc0fe0
The files in templates/gitea/ used a mix of naming styles: lowercase concatenations (poddisruptionbudget.yaml, serviceaccount.yaml, servicemonitor.yaml, pvc.yaml), camelCase (httpService.yaml, sshService.yaml) and kind-suffixed names (gpg-secret.yaml, metrics-secret.yaml). It was therefore not obvious from a file name which Kubernetes resource it renders, and the naming contradicted the camelCase convention the Gateway API templates already follow. Files are now named after the kind they render, with a lowercase suffix distinguishing several resources of the same kind: config.yaml -> secret_config.yaml + secret_inlineConfig.yaml gpg-secret.yaml -> secret_gpg.yaml init.yaml -> secret_init.yaml metrics-secret.yaml -> secret_metrics.yaml httpService.yaml -> service_http.yaml sshService.yaml -> service_ssh.yaml poddisruptionbudget.yaml -> podDisruptionBudget.yaml pvc.yaml -> persistentVolumeClaim.yaml serviceaccount.yaml -> serviceAccount.yaml servicemonitor.yaml -> serviceMonitor.yaml config.yaml rendered two Secrets from a single file, which forced every unit test to address them via documentIndex. It is split so that each file renders exactly one resource. The rendered manifests are unchanged; only file names and the references to them were touched. This includes the checksum/config annotation in deployment.yaml and all helm unit test suites. The HA guard assertions had to move from deployment.yaml to secret_config.yaml: Helm sorts templates in reverse alphabetical order, so secret_config.yaml is now rendered before deployment.yaml and the fail() is reported for that file directly instead of bubbling up through the include chain of the Deployment. Users relying on the template paths (e.g. `helm template --show-only` or post-renderers) have to adjust to the new file names. Co-authored-by: Copilot <copilot@github.com>
111 lines
4.0 KiB
YAML
111 lines
4.0 KiB
YAML
suite: deployment template (image configuration)
|
|
release:
|
|
name: gitea-unittests
|
|
namespace: testing
|
|
chart:
|
|
# Override appVersion to be consistent with used digest :)
|
|
appVersion: 1.19.3
|
|
templates:
|
|
- templates/gitea/deployment.yaml
|
|
- templates/gitea/secret_config.yaml
|
|
tests:
|
|
- it: default values
|
|
template: templates/gitea/deployment.yaml
|
|
asserts:
|
|
- equal:
|
|
path: spec.template.spec.containers[0].image
|
|
value: "docker.gitea.com/gitea:1.19.3-rootless"
|
|
- it: tag override
|
|
template: templates/gitea/deployment.yaml
|
|
set:
|
|
image.tag: "1.19.4"
|
|
asserts:
|
|
- equal:
|
|
path: spec.template.spec.containers[0].image
|
|
value: "docker.gitea.com/gitea:1.19.4-rootless"
|
|
- it: root-based image
|
|
template: templates/gitea/deployment.yaml
|
|
set:
|
|
image.rootless: false
|
|
asserts:
|
|
- equal:
|
|
path: spec.template.spec.containers[0].image
|
|
value: "docker.gitea.com/gitea:1.19.3"
|
|
- it: scoped registry
|
|
template: templates/gitea/deployment.yaml
|
|
set:
|
|
image.registry: "example.com"
|
|
asserts:
|
|
- equal:
|
|
path: spec.template.spec.containers[0].image
|
|
value: "example.com/gitea:1.19.3-rootless"
|
|
- it: global registry
|
|
template: templates/gitea/deployment.yaml
|
|
set:
|
|
global.imageRegistry: "global.example.com"
|
|
asserts:
|
|
- equal:
|
|
path: spec.template.spec.containers[0].image
|
|
value: "global.example.com/gitea:1.19.3-rootless"
|
|
- it: digest for rootless image
|
|
template: templates/gitea/deployment.yaml
|
|
set:
|
|
image:
|
|
rootless: true
|
|
digest: sha256:b28e8f3089b52ebe6693295df142f8c12eff354e9a4a5bfbb5c10f296c3a537a
|
|
asserts:
|
|
- equal:
|
|
path: spec.template.spec.containers[0].image
|
|
value: "docker.gitea.com/gitea:1.19.3-rootless@sha256:b28e8f3089b52ebe6693295df142f8c12eff354e9a4a5bfbb5c10f296c3a537a"
|
|
- it: image fullOverride (does not append rootless)
|
|
template: templates/gitea/deployment.yaml
|
|
set:
|
|
image:
|
|
fullOverride: docker.gitea.com/gitea:1.19.3
|
|
# setting rootless, registry, repository, tag, and digest to prove that override works
|
|
rootless: true
|
|
registry: example.com
|
|
repository: example/image
|
|
tag: "1.0.0"
|
|
digest: sha256:b28e8f3089b52ebe6693295df142f8c12eff354e9a4a5bfbb5c10f296c3a537a
|
|
asserts:
|
|
- equal:
|
|
path: spec.template.spec.containers[0].image
|
|
value: "docker.gitea.com/gitea:1.19.3"
|
|
- it: digest for root-based image
|
|
template: templates/gitea/deployment.yaml
|
|
set:
|
|
image:
|
|
rootless: false
|
|
digest: sha256:b28e8f3089b52ebe6693295df142f8c12eff354e9a4a5bfbb5c10f296c3a537a
|
|
asserts:
|
|
- equal:
|
|
path: spec.template.spec.containers[0].image
|
|
value: "docker.gitea.com/gitea:1.19.3@sha256:b28e8f3089b52ebe6693295df142f8c12eff354e9a4a5bfbb5c10f296c3a537a"
|
|
- it: digest and global registry
|
|
template: templates/gitea/deployment.yaml
|
|
set:
|
|
global.imageRegistry: "global.example.com"
|
|
image.digest: "sha256:b28e8f3089b52ebe6693295df142f8c12eff354e9a4a5bfbb5c10f296c3a537a"
|
|
asserts:
|
|
- equal:
|
|
path: spec.template.spec.containers[0].image
|
|
value: "global.example.com/gitea:1.19.3-rootless@sha256:b28e8f3089b52ebe6693295df142f8c12eff354e9a4a5bfbb5c10f296c3a537a"
|
|
- it: correctly renders floating tag references
|
|
template: templates/gitea/deployment.yaml
|
|
set:
|
|
image.tag: 1.21 # use non-quoted value on purpose. See: https://gitea.com/gitea/helm-gitea/issues/631
|
|
asserts:
|
|
- equal:
|
|
path: spec.template.spec.initContainers[0].image
|
|
value: "docker.gitea.com/gitea:1.21-rootless"
|
|
- equal:
|
|
path: spec.template.spec.initContainers[1].image
|
|
value: "docker.gitea.com/gitea:1.21-rootless"
|
|
- equal:
|
|
path: spec.template.spec.initContainers[2].image
|
|
value: "docker.gitea.com/gitea:1.21-rootless"
|
|
- equal:
|
|
path: spec.template.spec.containers[0].image
|
|
value: "docker.gitea.com/gitea:1.21-rootless"
|