volker.raschekandCopilot
e17a4e7a7b
An Ingress that points at a Service which the chart does not render is broken by definition: the backend reference cannot resolve and the ingress controller reports the rule as unavailable. The render condition therefore now also requires `service.http.enabled` and lives in the new `gitea.ingress.enabled` helper, so the same rule can be reused by other templates instead of being duplicated. The namespace is taken from `.Release.Namespace` again. The `namespace` value is not a documented chart parameter, and letting a single resource opt out of the release namespace breaks `helm uninstall` and Argo CD pruning, because neither tracks objects outside the release namespace. The `ingress.className` default changes from an empty string to `nginx`. An empty class makes the cluster fall back to the default IngressClass, which silently produces a different result per cluster; naming the controller the chart is tested against makes the rendered output predictable. The scattered ingress suites are consolidated into a single `unittests/helm/ingress/ingress.yaml` that pins the release name, namespace and appVersion, as required by the testing conventions, and covers the enable/disable matrix, annotations, labels, TLS and a custom HTTP port. BREAKING CHANGE: The Ingress is no longer rendered when `service.http.enabled` is `false`. `ingress.className` now defaults to `nginx` instead of the cluster's default IngressClass. The undocumented `namespace` value no longer applies to the Ingress. Co-authored-by: Copilot <copilot@github.com>
143 lines
3.6 KiB
YAML
143 lines
3.6 KiB
YAML
suite: Test ingress.yaml
|
|
chart:
|
|
appVersion: 1.27.3
|
|
release:
|
|
name: gitea-unittest
|
|
namespace: gitea-debug
|
|
templates:
|
|
- templates/gitea/ingress.yaml
|
|
tests:
|
|
- it: Skip ingress if ingress is disabled
|
|
set:
|
|
ingress.enabled: false
|
|
service.http.enabled: true
|
|
asserts:
|
|
- hasDocuments:
|
|
count: 0
|
|
|
|
- it: Skip ingress if HTTP Service is disabled
|
|
set:
|
|
ingress.enabled: true
|
|
service.http.enabled: false
|
|
asserts:
|
|
- hasDocuments:
|
|
count: 0
|
|
|
|
- it: Skip ingress if both ingress and HTTP Service are disabled
|
|
set:
|
|
ingress.enabled: false
|
|
service.http.enabled: false
|
|
asserts:
|
|
- hasDocuments:
|
|
count: 0
|
|
|
|
- it: Render ingress with default values
|
|
set:
|
|
ingress.enabled: true
|
|
service.http.enabled: true
|
|
asserts:
|
|
- hasDocuments:
|
|
count: 1
|
|
- containsDocument:
|
|
kind: Ingress
|
|
apiVersion: networking.k8s.io/v1
|
|
name: gitea-unittest
|
|
namespace: gitea-debug
|
|
- notExists:
|
|
path: metadata.annotations
|
|
- isSubset:
|
|
path: metadata.labels
|
|
content:
|
|
app: gitea
|
|
app.kubernetes.io/instance: gitea-unittest
|
|
app.kubernetes.io/managed-by: Helm
|
|
app.kubernetes.io/name: gitea
|
|
app.kubernetes.io/version: 1.27.3
|
|
helm.sh/chart: gitea-0.0.0
|
|
version: 1.27.3
|
|
- equal:
|
|
path: spec.ingressClassName
|
|
value: nginx
|
|
- contains:
|
|
path: spec.rules
|
|
content:
|
|
host: git.example.com
|
|
http:
|
|
paths:
|
|
- backend:
|
|
service:
|
|
name: gitea-unittest-http
|
|
port:
|
|
number: 3000
|
|
path: /
|
|
pathType: Prefix
|
|
|
|
- it: Render ingress with TLS
|
|
set:
|
|
ingress.enabled: true
|
|
ingress.tls:
|
|
- hosts:
|
|
- git.example.com
|
|
secretName: tls-secret
|
|
service.http.enabled: true
|
|
asserts:
|
|
- hasDocuments:
|
|
count: 1
|
|
- contains:
|
|
path: spec.tls
|
|
content:
|
|
hosts:
|
|
- git.example.com
|
|
secretName: tls-secret
|
|
|
|
- it: Render ingress with custom HTTP service spec
|
|
set:
|
|
ingress.enabled: true
|
|
service.http.enabled: true
|
|
service.http.port: 32000
|
|
asserts:
|
|
- hasDocuments:
|
|
count: 1
|
|
- containsDocument:
|
|
kind: Ingress
|
|
apiVersion: networking.k8s.io/v1
|
|
name: gitea-unittest
|
|
namespace: gitea-debug
|
|
- contains:
|
|
path: spec.rules
|
|
content:
|
|
host: git.example.com
|
|
http:
|
|
paths:
|
|
- backend:
|
|
service:
|
|
name: gitea-unittest-http
|
|
port:
|
|
number: 32000
|
|
path: /
|
|
pathType: Prefix
|
|
|
|
- it: Render ingress with custom annotations and labels
|
|
set:
|
|
ingress.enabled: true
|
|
ingress.annotations:
|
|
custom-annotation: custom-value
|
|
ingress.labels:
|
|
custom-label: custom-value
|
|
service.http.enabled: true
|
|
asserts:
|
|
- hasDocuments:
|
|
count: 1
|
|
- containsDocument:
|
|
kind: Ingress
|
|
apiVersion: networking.k8s.io/v1
|
|
name: gitea-unittest
|
|
namespace: gitea-debug
|
|
- isSubset:
|
|
path: metadata.annotations
|
|
content:
|
|
custom-annotation: custom-value
|
|
- isSubset:
|
|
path: metadata.labels
|
|
content:
|
|
custom-label: custom-value |