volker.raschekandCopilot
eeacda2a25
The chart conventions demand camelCase file names, forbid short names like `svc` and require the unit tests to
mirror the template structure. The unit tests followed none of that consistently. Four casings existed side by
side - camelCase (extraInitContainers.yaml), kebab-case (checksum-annotations.yaml), a snake and kebab mix
(init_directory_structure.sh-rootless.yaml) and all caps (HA.yaml) - so there was no pattern to copy when
adding a suite, which is how the inconsistency kept growing.
Three groups of problems are fixed:
- svc-configuration.yaml used exactly the short name the conventions forbid for files and keys.
- Several file names repeated their own directory, for example deployment/deployment-additional-config.yaml and
metric-secret/metrics-secret-servicemonitor-disabled.yaml, which names the subject three times. The directory
already carries that information, so the file name now only carries the scenario. The default scenario of a
template is named basics.yaml.
- Four suites lived in a directory of a template they do not assert on. They were filed under deployment/
because the deployment is rendered as a side effect, not because it is the subject:
deployment/deprecations.yaml -> deprecation/deployment.yaml
deployment/inline-config.yaml -> config/inlineConfig.yaml
deployment/storage-class-configuration.yaml -> persistentVolumeClaim/storageClass.yaml
deployment/svc-configuration.yaml -> service/configuration.yaml
storage-class-configuration.yaml is the clearest case: a persistentVolumeClaim directory already existed next
to it. The suite titles of the two suites whose subject changed are adjusted accordingly.
The Makefile passed `--file unittests/helm/values-conflicting-checks.yaml`, but that file does not exist in the
tree. `helm unittest` ignores a missing path without a warning, so the flag has been dead for an unknown amount
of time while still suggesting the checks run. It is removed; the `unittests/helm/**/*.yaml` glob would pick
the file up anyway if it ever returns.
The naming rule is written down in the copilot instructions, together with the constraint that the glob matches
only a single directory level, so a suite can never be placed directly in unittests/helm/.
All 49 suites and 267 tests still pass.
Co-authored-by: Copilot <copilot@github.com>
176 lines
4.9 KiB
YAML
176 lines
4.9 KiB
YAML
suite: Test config server domain
|
|
release:
|
|
name: gitea-unittests
|
|
namespace: testing
|
|
tests:
|
|
- it: "[default values] Use the ingress host for DOMAIN|SSH_DOMAIN|ROOT_URL"
|
|
template: templates/secret_inlineConfig.yaml
|
|
asserts:
|
|
- documentIndex: 0
|
|
matchRegex:
|
|
path: data.server
|
|
decodeBase64: true
|
|
pattern: \nDOMAIN=git.example.com
|
|
- documentIndex: 0
|
|
matchRegex:
|
|
path: data.server
|
|
decodeBase64: true
|
|
pattern: \nSSH_DOMAIN=git.example.com
|
|
- documentIndex: 0
|
|
matchRegex:
|
|
path: data.server
|
|
decodeBase64: true
|
|
pattern: \nROOT_URL=http://git.example.com
|
|
|
|
################################################
|
|
|
|
- it: "[no ingress hosts] Use the HTTP Service for DOMAIN|SSH_DOMAIN|ROOT_URL"
|
|
template: templates/secret_inlineConfig.yaml
|
|
set:
|
|
ingress:
|
|
hosts: []
|
|
asserts:
|
|
- documentIndex: 0
|
|
matchRegex:
|
|
path: data.server
|
|
decodeBase64: true
|
|
pattern: \nDOMAIN=gitea-unittests-http.testing.svc.cluster.local
|
|
- documentIndex: 0
|
|
matchRegex:
|
|
path: data.server
|
|
decodeBase64: true
|
|
pattern: \nSSH_DOMAIN=gitea-unittests-http.testing.svc.cluster.local
|
|
- documentIndex: 0
|
|
matchRegex:
|
|
path: data.server
|
|
decodeBase64: true
|
|
pattern: \nROOT_URL=http://gitea-unittests-http.testing.svc.cluster.local
|
|
|
|
################################################
|
|
|
|
- it: "[provided via values] Use the configured values for DOMAIN|SSH_DOMAIN|ROOT_URL"
|
|
template: templates/secret_inlineConfig.yaml
|
|
set:
|
|
gitea.config.server.DOMAIN: provided.example.com
|
|
ingress:
|
|
hosts:
|
|
- host: non-used.example.com
|
|
paths:
|
|
- path: /
|
|
pathType: Prefix
|
|
asserts:
|
|
- documentIndex: 0
|
|
matchRegex:
|
|
path: data.server
|
|
decodeBase64: true
|
|
pattern: \nDOMAIN=provided.example.com
|
|
- documentIndex: 0
|
|
matchRegex:
|
|
path: data.server
|
|
decodeBase64: true
|
|
pattern: \nSSH_DOMAIN=provided.example.com
|
|
- documentIndex: 0
|
|
matchRegex:
|
|
path: data.server
|
|
decodeBase64: true
|
|
pattern: \nROOT_URL=http://provided.example.com
|
|
|
|
################################################
|
|
|
|
- it: "[route enabled] Use the Route host for DOMAIN|SSH_DOMAIN|ROOT_URL"
|
|
template: templates/secret_inlineConfig.yaml
|
|
set:
|
|
route:
|
|
enabled: true
|
|
host: route.example.com
|
|
asserts:
|
|
- documentIndex: 0
|
|
matchRegex:
|
|
path: data.server
|
|
decodeBase64: true
|
|
pattern: \nDOMAIN=route.example.com
|
|
- documentIndex: 0
|
|
matchRegex:
|
|
path: data.server
|
|
decodeBase64: true
|
|
pattern: \nSSH_DOMAIN=route.example.com
|
|
- documentIndex: 0
|
|
matchRegex:
|
|
path: data.server
|
|
decodeBase64: true
|
|
pattern: \nROOT_URL=http://route.example.com
|
|
|
|
################################################
|
|
|
|
- it: "[route tls termination] Use https for ROOT_URL"
|
|
template: templates/secret_inlineConfig.yaml
|
|
set:
|
|
route:
|
|
enabled: true
|
|
host: route.example.com
|
|
tls:
|
|
termination: edge
|
|
asserts:
|
|
- documentIndex: 0
|
|
matchRegex:
|
|
path: data.server
|
|
decodeBase64: true
|
|
pattern: \nROOT_URL=https://route.example.com
|
|
|
|
################################################
|
|
|
|
- it: "[HTTPRoute enabled] Use the first hostname for DOMAIN|SSH_DOMAIN|ROOT_URL"
|
|
template: templates/secret_inlineConfig.yaml
|
|
set:
|
|
ingress:
|
|
hosts: []
|
|
gatewayAPI:
|
|
enabled: true
|
|
core:
|
|
httpRoute:
|
|
enabled: true
|
|
hostnames:
|
|
- gw.example.com
|
|
parentRefs:
|
|
- name: shared-gateway
|
|
asserts:
|
|
- documentIndex: 0
|
|
matchRegex:
|
|
path: data.server
|
|
decodeBase64: true
|
|
pattern: \nDOMAIN=gw.example.com
|
|
- documentIndex: 0
|
|
matchRegex:
|
|
path: data.server
|
|
decodeBase64: true
|
|
pattern: \nSSH_DOMAIN=gw.example.com
|
|
- documentIndex: 0
|
|
matchRegex:
|
|
path: data.server
|
|
decodeBase64: true
|
|
pattern: \nROOT_URL=http://gw.example.com
|
|
|
|
################################################
|
|
|
|
- it: "[HTTPRoute tls] Switch ROOT_URL to https"
|
|
template: templates/secret_inlineConfig.yaml
|
|
set:
|
|
ingress:
|
|
hosts: []
|
|
gatewayAPI:
|
|
enabled: true
|
|
core:
|
|
httpRoute:
|
|
enabled: true
|
|
tls: true
|
|
hostnames:
|
|
- gw.example.com
|
|
parentRefs:
|
|
- name: shared-gateway
|
|
asserts:
|
|
- documentIndex: 0
|
|
matchRegex:
|
|
path: data.server
|
|
decodeBase64: true
|
|
pattern: \nROOT_URL=https://gw.example.com
|