volker.raschekandCopilot
fef4190a74
Bash / bash-unittest (push) Successful in 14s
Bash / shellcheck (push) Successful in 20s
changelog / changelog (push) Successful in 16s
Helm / helm-lint (push) Successful in 15s
Helm / helm-unittest (push) Successful in 32s
Markdown linter / markdown-lint (push) Successful in 15s
Markdown linter / markdown-link-checker (push) Successful in 56s
The contributor guidelines never defined how a `suite` title has to look, only how an `it` title has to look. Without a rule five competing schemes grew side by side: `config template | cache config`, `deployment template (probes)`, `ServiceMonitor template (basic)`, `Test Gateway API httpRoute.yaml` and `Dependency checks | Customization integrity | valkey`. 24 of the 49 titles started with a lowercase letter, which contradicts the sentence rule that already applies to the test titles. More than cosmetics, the missing rule produced three concrete defects: - `deployment template` was used by both deployment-additional-config.yaml and extraInitContainers.yaml, and `Init template` by both init_directory_structure.sh.yaml and its rootless counterpart. `helm unittest` identifies a failing suite by its title, so a failure in either file printed the same header and the report did not say which file to open. - deployment/inline-config.yaml was titled `config template`, although it lives in the deployment directory and asserts on secret_inlineConfig.yaml. It read like a sixth member of the `config template | ...` group. - persistentVolumeClaim.yaml was titled `PVC template`, using exactly the short name the chart conventions forbid for files and keys. All suites now follow `Test <subject> <scenario>`, for example `Test deployment probes` or `Test gateway API httpRoute`. The subject is the template under test, the scenario is what distinguishes the suite from its siblings, so every title is unique and sorts next to its related suites. The `Test ` prefix of the Gateway API, ingress and route suites is kept, because it is the only part of the old schemes that already read as a sentence; the redundant `.yaml` suffix and the `tests` suffix of the storage class suite are dropped. The rule is written down in the Unit Tests section of the copilot instructions, so the next suite does not have to guess which of the five schemes was meant. Co-authored-by: Copilot <copilot@github.com>
90 lines
2.8 KiB
YAML
90 lines
2.8 KiB
YAML
suite: Test serviceMonitor basics
|
|
release:
|
|
name: gitea-unittests
|
|
namespace: testing
|
|
templates:
|
|
- templates/serviceMonitor.yaml
|
|
tests:
|
|
- it: "Skip rendering by default"
|
|
asserts:
|
|
- hasDocuments:
|
|
count: 0
|
|
- it: "Render the ServiceMonitor when gitea.metrics.enabled is true"
|
|
set:
|
|
gitea.metrics.enabled: true
|
|
asserts:
|
|
- hasDocuments:
|
|
count: 0
|
|
- it: "Render the ServiceMonitor when gitea.metrics.serviceMonitor.enabled is true"
|
|
set:
|
|
gitea.metrics.serviceMonitor.enabled: true
|
|
asserts:
|
|
- hasDocuments:
|
|
count: 0
|
|
- it: "Render the default ServiceMonitor spec"
|
|
set:
|
|
gitea.metrics.enabled: true
|
|
gitea.metrics.serviceMonitor.enabled: true
|
|
asserts:
|
|
- hasDocuments:
|
|
count: 1
|
|
- containsDocument:
|
|
kind: ServiceMonitor
|
|
apiVersion: monitoring.coreos.com/v1
|
|
name: gitea-unittests
|
|
- notExists:
|
|
path: metadata.annotations
|
|
- notExists:
|
|
path: spec.endpoints[0].interval
|
|
- equal:
|
|
path: spec.endpoints[0].port
|
|
value: http
|
|
- notExists:
|
|
path: spec.endpoints[0].scheme
|
|
- notExists:
|
|
path: spec.endpoints[0].scrapeTimeout
|
|
- notExists:
|
|
path: spec.endpoints[0].tlsConfig
|
|
- it: "Render a custom scrape interval"
|
|
set:
|
|
gitea.metrics.enabled: true
|
|
gitea.metrics.serviceMonitor.enabled: true
|
|
gitea.metrics.serviceMonitor.interval: 30s
|
|
gitea.metrics.serviceMonitor.scrapeTimeout: 5s
|
|
asserts:
|
|
- equal:
|
|
path: spec.endpoints[0].interval
|
|
value: 30s
|
|
- equal:
|
|
path: spec.endpoints[0].scrapeTimeout
|
|
value: 5s
|
|
- it: "Render a custom tls config"
|
|
set:
|
|
gitea.metrics.enabled: true
|
|
gitea.metrics.serviceMonitor.enabled: true
|
|
gitea.metrics.serviceMonitor.scheme: https
|
|
gitea.metrics.serviceMonitor.tlsConfig.caFile: /etc/prometheus/tls/ca.crt
|
|
gitea.metrics.serviceMonitor.tlsConfig.certFile: /etc/prometheus/tls/tls.crt
|
|
gitea.metrics.serviceMonitor.tlsConfig.keyFile: /etc/prometheus/tls/tls.key
|
|
gitea.metrics.serviceMonitor.tlsConfig.insecureSkipVerify: false
|
|
gitea.metrics.serviceMonitor.tlsConfig.serverName: gitea-unittest
|
|
asserts:
|
|
- equal:
|
|
path: spec.endpoints[0].scheme
|
|
value: https
|
|
- equal:
|
|
path: spec.endpoints[0].tlsConfig.caFile
|
|
value: /etc/prometheus/tls/ca.crt
|
|
- equal:
|
|
path: spec.endpoints[0].tlsConfig.certFile
|
|
value: /etc/prometheus/tls/tls.crt
|
|
- equal:
|
|
path: spec.endpoints[0].tlsConfig.keyFile
|
|
value: /etc/prometheus/tls/tls.key
|
|
- equal:
|
|
path: spec.endpoints[0].tlsConfig.insecureSkipVerify
|
|
value: false
|
|
- equal:
|
|
path: spec.endpoints[0].tlsConfig.serverName
|
|
value: gitea-unittest
|