add tests for empty auth

auth/empty.go

@@ -0,0 +1,14 @@
+package auth
+
+import "net/http"
+
+func NewEmptyAuthProvider() AuthProvider {
+	return &emptyAuthProvider{}
+}
+
+type emptyAuthProvider struct {
+}
+
+func (p *emptyAuthProvider) IsAllowed(request *http.Request) bool {
+	return true
+}

auth/empty_test.go

@@ -0,0 +1,36 @@
+package auth
+
+import (
+	"net/http"
+	"net/http/httptest"
+	"testing"
+)
+
+func Test_GIVEN_EmptyAuth_WHEN_CallingIsAllowedWithoutAuth_THEN_TrueReturned(t *testing.T) {
+	// assemble
+	request := httptest.NewRequest(http.MethodGet, "http://example.com", nil)
+	provider := NewEmptyAuthProvider()
+
+	// act
+	response := provider.IsAllowed(request)
+
+	// assert
+	if !response {
+		t.Errorf("expected request to be allowed, but failed")
+	}
+}
+
+func Test_GIVEN_EmptyAuth_WHEN_CallingIsAllowedWithAuth_THEN_TrueReturned(t *testing.T) {
+	// assemble
+	request := httptest.NewRequest(http.MethodGet, "http://example.com", nil)
+	request.SetBasicAuth("user", "pass")
+	provider := NewEmptyAuthProvider()
+
+	// act
+	response := provider.IsAllowed(request)
+
+	// assert
+	if !response {
+		t.Errorf("expected request to be allowed, but failed")
+	}
+}

auth/provider.go

@@ -7,28 +7,3 @@ import (
 type AuthProvider interface {
 	IsAllowed(*http.Request) bool
 }
-
-func NewEmptyAuthProvider() AuthProvider {
-	return &emptyAuthProvider{}
-}
-
-type emptyAuthProvider struct {
-}
-
-func (p *emptyAuthProvider) IsAllowed(request *http.Request) bool {
-	return true
-}
-
-type compositeAuthProvider struct {
-	providers []AuthProvider
-}
-
-func (p *compositeAuthProvider) IsAllowed(request *http.Request) bool {
-	for i := 0; i < len(p.providers); i++ {
-		provider := p.providers[i]
-		if provider.IsAllowed(request) {
-			return true
-		}
-	}
-	return false
-}