fix(shellyctl): align PKGBUILD with Arch Go package guidelines

- Add prepare() with GOPATH and go mod download for reproducible builds
- Remove redundant CLI flags from go build, rely on GOFLAGS export
- Add GOPATH="${srcdir}" to build() as recommended by guidelines
- Add check() function running go test
- Fix license file permissions from 0755 to 0644

Co-authored-by: Copilot <copilot@github.com>

.SRCINFO

@@ -1,7 +1,7 @@
 pkgbase = shellyctl
 	pkgdesc = shellyctl is an unofficial command line client for the Shelly Gen2/3 API.
 	pkgver = 0.4.0
-	pkgrel = 1
+	pkgrel = 3
 	url = https://github.com/jcodybaker/shellyctl
 	arch = armv7h
 	arch = aarch64

.drone.yml

@@ -1,97 +0,0 @@
----
-kind: pipeline
-type: kubernetes
-name: linter
-
-clone:
-  disable: true
-
-steps:
-- name: clone
-  image: git.cryptic.systems/volker.raschek/git:1.4.0
-
-- name: markdown lint
-  commands:
-  - markdownlint *.md
-  image: git.cryptic.systems/volker.raschek/markdownlint:0.43.0
-  resources:
-    limits:
-      cpu: 150
-      memory: 150M
-
-- name: email-notification
-  environment:
-    SMTP_FROM_ADDRESS:
-      from_secret: smtp_from_address
-    SMTP_FROM_NAME:
-      from_secret: smtp_from_name
-    SMTP_HOST:
-      from_secret: smtp_host
-    SMTP_USERNAME:
-      from_secret: smtp_username
-    SMTP_PASSWORD:
-      from_secret: smtp_password
-  image: git.cryptic.systems/volker.raschek/drone-email:0.1.5
-  resources:
-    limits:
-      cpu: 150
-      memory: 150M
-  when:
-    status:
-    - changed
-    - failure
-
-trigger:
-  event:
-    exclude:
-    - tag
-
----
-kind: pipeline
-type: kubernetes
-name: sync-to-aur.archlinux.org
-
-clone:
-  disable: true
-
-steps:
-- name: clone
-  image: git.cryptic.systems/volker.raschek/git:1.4.0
-
-- name: git-push
-  image: docker.io/appleboy/drone-git-push:1.1.1
-  settings:
-    branch: master
-    remote: ssh://aur@aur.archlinux.org/prometheus-x509-certificate-exporter.git
-    force: false
-    commit: false
-    ssh_key:
-      from_secret: aur_ssh_key
-
-- name: email-notification
-  environment:
-    SMTP_FROM_ADDRESS:
-      from_secret: smtp_from_address
-    SMTP_FROM_NAME:
-      from_secret: smtp_from_name
-    SMTP_HOST:
-      from_secret: smtp_host
-    SMTP_USERNAME:
-      from_secret: smtp_username
-    SMTP_PASSWORD:
-      from_secret: smtp_password
-  image: git.cryptic.systems/volker.raschek/drone-email:0.1.5
-  resources:
-    limits:
-      cpu: 150
-      memory: 150M
-  when:
-    status:
-    - changed
-    - failure
-
-trigger:
-  event:
-  - tag
-  repo:
-  - volker.raschek/prometheus-x509-certificate-exporter-pkg

.markdownlint.yaml

@@ -1,145 +0,0 @@
-# markdownlint YAML configuration
-# https://github.com/DavidAnson/markdownlint/blob/main/schema/.markdownlint.yaml
-
-# Default state for all rules
-default: true
-
-# Path to configuration file to extend
-extends: null
-
-# MD003/heading-style/header-style - Heading style
-MD003:
-  # Heading style
-  style: "atx"
-
-# MD004/ul-style - Unordered list style
-MD004:
-  style: "dash"
-
-# MD007/ul-indent - Unordered list indentation
-MD007:
-  # Spaces for indent
-  indent: 2
-  # Whether to indent the first level of the list
-  start_indented: false
-
-# MD009/no-trailing-spaces - Trailing spaces
-MD009:
-  # Spaces for line break
-  br_spaces: 2
-  # Allow spaces for empty lines in list items
-  list_item_empty_lines: false
-  # Include unnecessary breaks
-  strict: false
-
-# MD010/no-hard-tabs - Hard tabs
-MD010:
-  # Include code blocks
-  code_blocks: true
-
-# MD012/no-multiple-blanks - Multiple consecutive blank lines
-MD012:
-  # Consecutive blank lines
-  maximum: 1
-
-# MD013/line-length - Line length
-MD013:
-  # Number of characters
-  line_length: 120
-  # Number of characters for headings
-  heading_line_length: 120
-  # Number of characters for code blocks
-  code_block_line_length: 120
-  # Include code blocks
-  code_blocks: false
-  # Include tables
-  tables: false
-  # Include headings
-  headings: true
-  # Include headings
-  headers: true
-  # Strict length checking
-  strict: false
-  # Stern length checking
-  stern: false
-
-# MD022/blanks-around-headings/blanks-around-headers - Headings should be surrounded by blank lines
-MD022:
-  # Blank lines above heading
-  lines_above: 1
-  # Blank lines below heading
-  lines_below: 1
-
-# MD024/no-duplicate-heading/no-duplicate-header - Multiple headings with the same content
-MD024:
-  # Only check sibling headings
-  allow_different_nesting: true
-
-# MD025/single-title/single-h1 - Multiple top-level headings in the same document
-MD025:
-  # Heading level
-  level: 1
-  # RegExp for matching title in front matter
-  front_matter_title: "^\\s*title\\s*[:=]"
-
-# MD026/no-trailing-punctuation - Trailing punctuation in heading
-MD026:
-  # Punctuation characters
-  punctuation: ".,;:!。，；：！"
-
-# MD029/ol-prefix - Ordered list item prefix
-MD029:
-  # List style
-  style: "one_or_ordered"
-
-# MD030/list-marker-space - Spaces after list markers
-MD030:
-  # Spaces for single-line unordered list items
-  ul_single: 1
-  # Spaces for single-line ordered list items
-  ol_single: 1
-  # Spaces for multi-line unordered list items
-  ul_multi: 1
-  # Spaces for multi-line ordered list items
-  ol_multi: 1
-
-# MD033/no-inline-html - Inline HTML
-MD033:
-  # Allowed elements
-  allowed_elements: []
-
-# MD035/hr-style - Horizontal rule style
-MD035:
-  # Horizontal rule style
-  style: "---"
-
-# MD036/no-emphasis-as-heading/no-emphasis-as-header - Emphasis used instead of a heading
-MD036:
-  # Punctuation characters
-  punctuation: ".,;:!?。，；：！？"
-
-# MD041/first-line-heading/first-line-h1 - First line in a file should be a top-level heading
-MD041:
-  # Heading level
-  level: 1
-  # RegExp for matching title in front matter
-  front_matter_title: "^\\s*title\\s*[:=]"
-
-# MD044/proper-names - Proper names should have the correct capitalization
-MD044:
-  # List of proper names
-  names:
-  - Arch Linux
-  - Linux Mint
-  # Include code blocks
-  code_blocks: false
-
-# MD046/code-block-style - Code block style
-MD046:
-  # Block style
-  style: "fenced"
-
-# MD048/code-fence-style - Code fence style
-MD048:
-  # Code fence syle
-  style: "backtick"

PKGBUILD

@@ -1,8 +1,8 @@
 # Maintainer: Markus Pesch <markus.pesch plus apps at cryptic.systems>
 
 pkgname=shellyctl
-pkgver=0.4.0 # renovate: datasource=github-releases depName=jcodybaker/shellyctl
+pkgver=0.4.2 # renovate: datasource=github-releases depName=jcodybaker/shellyctl
-pkgrel=1
+pkgrel=3
 pkgdesc="shellyctl is an unofficial command line client for the Shelly Gen2/3 API. "
 arch=('armv7h' 'aarch64' 'x86_64')
 url="https://github.com/jcodybaker/$pkgname"
@@ -12,8 +12,21 @@ makedepends=('go')
 source=(
   "$url/archive/refs/tags/v$pkgver.zip"
 )
-sha512sums=('fd997360d5a1804c642422833c602966acd196dc6668d596b5a1d6eefbd619a54154e5a355b705383900374d284e9eef0066c16d9c997c893bddcd4a30ebd647')
+sha512sums=('2c19275204461c0449f4e638cbde8722a0387b147eaa77e2091d160b8c1233d061170ff3600293d116d1740166dacac3cc3ce79549f4558ed8adc5eb45efe224')
-b2sums=('394f831886dd0cf11c8b66feaa0f8a4511a322bdd44eb3cb06794d18b7f215694be00795e96225fe340d945421ec584d6af2afb9fdf1ad1b131d1bd01fc22a55')
+b2sums=('a525fc326b8435c936798214911417cca29251062aa968753d0f2f68eee188e66bf5dca16489cb7fd51818389e931e3d9cdf67376968255ab008a602982845a0')
+
+prepare() {
+  cd "$pkgname-$pkgver"
+
+  export GONOSUMDB="${GONOSUMDB}"
+  export GOPATH="${srcdir}"
+  export GOPROXY="${GOPROXY}"
+
+  # INFO: Print all Go related environment variables for debugging purposes.
+  env | sort | grep -E '^C?GO'
+
+  go mod download -modcacherw
+}
 
 build() {
   cd "$pkgname-$pkgver"
@@ -23,16 +36,15 @@ build() {
   export CGO_CFLAGS="${CFLAGS}"
   export CGO_CXXFLAGS="${CXXFLAGS}"
   export CGO_LDFLAGS="${LDFLAGS}"
+  export GOPATH="${srcdir}"
   export GOFLAGS="-buildmode=pie -trimpath -ldflags=-linkmode=external -mod=readonly -modcacherw"
 
-  go build -v \
+  go build -o $pkgname .
-    -trimpath \
+}
-    -buildmode=pie \
+
-    -mod=readonly \
+check() {
-    -modcacherw \
+  cd "$pkgname-$pkgver"
-    -ldflags "-linkmode external -extldflags \"${LDFLAGS}\"" \
+  go test ./...
-    -o $pkgname \
-    .
 }
 
 package() {
@@ -40,5 +52,5 @@ package() {
   install -D --mode 0755 --target-directory "$pkgdir/usr/bin" "$pkgname-$pkgver/$pkgname"
 
   # license
-  install -D --mode 0755 --target-directory "$pkgdir/usr/share/licenses/$pkgname" "$pkgname-$pkgver/LICENSE.md"
+  install -D --mode 0644 --target-directory "$pkgdir/usr/share/licenses/$pkgname" "$pkgname-$pkgver/LICENSE.md"
 }

README.md

@@ -1,7 +1,6 @@
 # shellyctl
 
 ![AUR version](https://img.shields.io/aur/version/shellyctl?label=AUR)
-[![Build Status](https://drone.cryptic.systems/api/badges/volker.raschek/shellyctl-pkg/status.svg)](https://drone.cryptic.systems/volker.raschek/shellyctl-pkg)
 ![AUR votes](https://img.shields.io/aur/votes/shellyctl)
 
 This repository contains build files to build the Arch Linux package `shellyctl`. Instead of

renovate.json

@@ -1,25 +1,9 @@
 {
   "$schema": "https://docs.renovatebot.com/renovate-schema.json",
-  "assignees": [ "volker.raschek" ],
+  "extends": [
-  "labels": [ "renovate" ],
+    "local>volker.raschek/renovate-config:default#master",
-  "packageRules": [
+    "local>volker.raschek/renovate-config:container#master",
-    {
+    "local>volker.raschek/renovate-config:actions#master",
-      "addLabels": [ "renovate/droneci", "renovate/automerge" ],
+    "local>volker.raschek/renovate-config:regexp#master"
-      "automerge": true,
-      "matchManagers": "droneci",
-      "matchUpdateTypes": [ "minor", "patch"]
-    }
-  ],
-  "rebaseLabel": "renovate/rebase",
-  "rebaseWhen": "behind-base-branch",
-  "regexManagers": [
-    {
-      "description": "Update PKGBUILD version",
-      "fileMatch": [ "(^|/)PKGBUILD$" ],
-      "matchStrings": [
-        "pkgver=(?<currentValue>.*) # renovate: datasource=(?<datasource>.*) depName=(?<depName>.*)( lookupName=(?<lookupName>.*))?( versioning=(?<versioning>.*))?"
-      ],
-      "extractVersionTemplate": "^v?(?<version>.*)$"
-    }
   ]
-}
+}