fix(scripts): shellcheck: SC2181

.gitea/workflows/shellcheck.yml

@@ -0,0 +1,15 @@
+name: Lint Shell files
+
+on:
+  pull_request:
+    branches: [ "*" ]
+    types: [ "opened", "edited" ]
+  workflow_dispatch: {}
+
+jobs:
+  shellcheck:
+    runs-on: ubuntu-latest
+    steps:
+    - uses: actions/checkout@v4.2.2
+    - run: apt install shellcheck
+    - run: find . -type f -name "*.sh" -exec shellcheck -a {} \;

scripts/token.sh

@@ -8,9 +8,14 @@ check_token() {
   set +e
 
   echo "Checking for existing token..."
-  token="$(kubectl get secret "$SECRET_NAME" -o jsonpath="{.data['token']}" 2> /dev/null)"
-  [ $? -ne 0 ] && return 1
-  [ -z "$token" ] && return 2
+  if ! token=$(kubectl get secret "${SECRET_NAME}" -o jsonpath="{.data['token']}" 2> /dev/null); then
+    return 1
+  fi
+
+  if [ -z "${token}" ]; then
+    return 2
+  fi
+
   return 0
 }