.editorconfig

@@ -9,4 +9,7 @@ indent_size = 2
 end_of_line = lf
 charset = utf-8
 trim_trailing_whitespace = false
-insert_final_newline = false
+insert_final_newline = false
+
+[Makefile]
+indent_style = tab

.gitea/workflows/shellcheck.yml

@@ -0,0 +1,14 @@
+name: Lint Shell files
+
+on:
+  pull_request:
+    branches: ["*"]
+    types: ["opened", "reopened", "synchronize"]
+
+jobs:
+  shellcheck:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4.2.2
+      - run: apt update --yes && apt install --yes shellcheck
+      - run: find . -type f -name "*.sh" -exec shellcheck -a {} \;

.gitea/workflows/test-pr.yml

@@ -47,3 +47,17 @@ jobs:
           git diff --exit-code --name-only README.md
       - name: yaml lint
         uses: https://github.com/ibiqlik/action-yamllint@v3
+
+  helm-schema-values:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4.2.2
+      - name: Generate values schema json
+        uses: losisin/helm-values-schema-json-action@v1.6.2
+        with:
+          input: values.yaml
+      - name: Verify values.schema.json
+        run: |
+          if ! git diff --exit-code --name-only values.schema.json; then
+            echo "Please update the values.schema.json and be carefully of breaking changes!" 2&>1
+          fi

Makefile

@@ -16,4 +16,7 @@ unittests-helm:
 .PHONY: helm
 update-helm-dependencies:
 	helm dependency update
-  
+
+.PHONY: yamllint
+yamllint:
+	yamllint -c .yamllint .

scripts/token.sh

@@ -8,9 +8,14 @@ check_token() {
   set +e
 
   echo "Checking for existing token..."
-  token="$(kubectl get secret "$SECRET_NAME" -o jsonpath="{.data['token']}" 2> /dev/null)"
-  [ $? -ne 0 ] && return 1
-  [ -z "$token" ] && return 2
+  if ! token=$(kubectl get secret "${SECRET_NAME}" -o jsonpath="{.data['token']}" 2> /dev/null); then
+    return 1
+  fi
+
+  if [ -z "${token}" ]; then
+    return 2
+  fi
+
   return 0
 }