volker.raschekandCopilot
6deb39df15
The PodSpec `hostUsers` field has nothing to do with the OpenShift compatibility profile. It only selects whether the pod shares the host's user namespace, which is a plain Kubernetes feature. Nesting it below `openshift` implied that it requires OpenShift and, worse, the helper only rendered it when `openshift.enabled` evaluated to `true`, so the setting was silently ignored on vanilla Kubernetes clusters. `gitea.hostUsers` now reads `deployment.hostUsers` and no longer depends on the OpenShift profile. The value is only rendered when it is an actual boolean, so the field stays omitted for `null` and the platform default applies. BREAKING CHANGE: `openshift.hostUsers` has been removed. Configure `deployment.hostUsers` instead. Co-authored-by: Copilot <copilot@github.com>
116 lines
3.5 KiB
YAML
116 lines
3.5 KiB
YAML
suite: deployment template (openshift)
|
|
release:
|
|
name: gitea-unittests
|
|
namespace: testing
|
|
templates:
|
|
- templates/gitea/deployment.yaml
|
|
- templates/gitea/secret_admin.yaml
|
|
- templates/gitea/secret_config.yaml
|
|
- templates/gitea/secret_gpg.yaml
|
|
- templates/gitea/secret_init.yaml
|
|
- templates/gitea/secret_inlineConfig.yaml
|
|
- templates/gitea/secret_metrics.yaml
|
|
tests:
|
|
- it: renders openshift-compatible defaults for chart-managed containers
|
|
template: templates/gitea/deployment.yaml
|
|
set:
|
|
openshift.enabled: true
|
|
asserts:
|
|
- notExists:
|
|
path: spec.template.spec.hostUsers
|
|
- notExists:
|
|
path: spec.template.spec.securityContext
|
|
- equal:
|
|
path: spec.template.spec.initContainers[0].securityContext
|
|
value:
|
|
allowPrivilegeEscalation: false
|
|
capabilities:
|
|
drop:
|
|
- ALL
|
|
runAsNonRoot: true
|
|
seccompProfile:
|
|
type: RuntimeDefault
|
|
- equal:
|
|
path: spec.template.spec.initContainers[1].securityContext
|
|
value:
|
|
allowPrivilegeEscalation: false
|
|
capabilities:
|
|
drop:
|
|
- ALL
|
|
runAsNonRoot: true
|
|
seccompProfile:
|
|
type: RuntimeDefault
|
|
- equal:
|
|
path: spec.template.spec.initContainers[2].securityContext
|
|
value:
|
|
allowPrivilegeEscalation: false
|
|
capabilities:
|
|
drop:
|
|
- ALL
|
|
runAsNonRoot: true
|
|
seccompProfile:
|
|
type: RuntimeDefault
|
|
- equal:
|
|
path: spec.template.spec.containers[0].securityContext
|
|
value:
|
|
allowPrivilegeEscalation: false
|
|
capabilities:
|
|
drop:
|
|
- ALL
|
|
runAsNonRoot: true
|
|
seccompProfile:
|
|
type: RuntimeDefault
|
|
|
|
- it: does not force runAsUser 1000 for command init containers on OpenShift
|
|
template: templates/gitea/deployment.yaml
|
|
set:
|
|
openshift.enabled: true
|
|
secrets.gpg.enabled: true
|
|
secrets.gpg.existingSecret.enabled: true
|
|
secrets.gpg.existingSecret.secretName: custom-gpg-secret
|
|
asserts:
|
|
- notExists:
|
|
path: spec.template.spec.initContainers[2].securityContext.runAsUser
|
|
- notExists:
|
|
path: spec.template.spec.initContainers[3].securityContext.runAsUser
|
|
|
|
- it: preserves explicit pod and container security context overrides on OpenShift
|
|
template: templates/gitea/deployment.yaml
|
|
set:
|
|
openshift:
|
|
enabled: true
|
|
deployment:
|
|
hostUsers: true
|
|
securityContext:
|
|
fsGroup: 1000620000
|
|
gitea:
|
|
securityContext:
|
|
runAsUser: 1000620000
|
|
runAsGroup: 1000620000
|
|
asserts:
|
|
- equal:
|
|
path: spec.template.spec.hostUsers
|
|
value: true
|
|
- equal:
|
|
path: spec.template.spec.securityContext
|
|
value:
|
|
fsGroup: 1000620000
|
|
- equal:
|
|
path: spec.template.spec.initContainers[2].securityContext.runAsUser
|
|
value: 1000620000
|
|
- equal:
|
|
path: spec.template.spec.containers[0].securityContext.runAsGroup
|
|
value: 1000620000
|
|
|
|
- it: renders an explicit hostUsers=false override on OpenShift
|
|
template: templates/gitea/deployment.yaml
|
|
set:
|
|
openshift:
|
|
enabled: true
|
|
deployment:
|
|
hostUsers: false
|
|
asserts:
|
|
- equal:
|
|
path: spec.template.spec.hostUsers
|
|
value: false
|