volker.raschekandCopilot
a4c6893874
The names of the Secrets rendered by the chart were built inline in each template and, for two of them, in ad-hoc chart-wide helpers. The same name therefore existed in several places (Deployment volumes, ServiceMonitor credentials, the Secret templates themselves), which made every rename a multi-file change and allowed the references to drift apart unnoticed - the Helm unit tests render one template at a time and cannot detect a mismatching secretName. All Secret names are now defined once in templates/gitea/_secrets.tpl: gitea.secret.config.name -> <fullname>-config gitea.secret.gpg.name -> <fullname>-gpg-key (or signing.existingSecret) gitea.secret.init.name -> <fullname>-init gitea.secret.inlineConfig.name -> <fullname>-inline-config gitea.secret.metrics.name -> <fullname>-metrics gitea.gpg-key-secret-name and gitea.metrics-secret-name are removed from _helpers.tpl accordingly. A checksum/inlineConfig pod annotation is added as well. After the inline configuration had been split out of secret_config.yaml, changes to it were no longer covered by any checksum annotation and did not trigger a rollout of the Deployment. Finally the metadata attributes of the Secret templates are sorted alphabetically as required by the chart conventions. BREAKING CHANGE: two Secrets are renamed. The config Secret changes from <fullname> to <fullname>-config and the metrics Secret from <fullname>-metrics-secret to <fullname>-metrics. Helm replaces both on upgrade; references to them from outside the chart have to be adjusted. Co-authored-by: Copilot <copilot@github.com>
152 lines
5.1 KiB
YAML
152 lines
5.1 KiB
YAML
suite: deployment template
|
|
release:
|
|
name: gitea-unittests
|
|
namespace: testing
|
|
templates:
|
|
- templates/gitea/deployment.yaml
|
|
- templates/gitea/secret_config.yaml
|
|
- templates/gitea/secret_inlineConfig.yaml
|
|
tests:
|
|
- it: Renders a deployment
|
|
template: templates/gitea/deployment.yaml
|
|
asserts:
|
|
- hasDocuments:
|
|
count: 1
|
|
- containsDocument:
|
|
kind: Deployment
|
|
apiVersion: apps/v1
|
|
name: gitea-unittests
|
|
- it: Deployment with empty additionalConfigFromEnvs
|
|
template: templates/gitea/deployment.yaml
|
|
set:
|
|
gitea.additionalConfigFromEnvs: []
|
|
asserts:
|
|
- hasDocuments:
|
|
count: 1
|
|
- exists:
|
|
path: spec.template.spec.initContainers[1].env
|
|
- lengthEqual:
|
|
path: spec.template.spec.initContainers[1].env
|
|
count: 6
|
|
- isSubset:
|
|
path: spec.template.spec.initContainers[1]
|
|
content:
|
|
env:
|
|
- name: GITEA_APP_INI
|
|
value: /data/gitea/conf/app.ini
|
|
- name: GITEA_CUSTOM
|
|
value: /data/gitea
|
|
- name: GITEA_WORK_DIR
|
|
value: /data
|
|
- name: GITEA_TEMP
|
|
value: /tmp/gitea
|
|
- name: TMP_EXISTING_ENVS_FILE
|
|
value: /tmp/existing-envs
|
|
- name: ENV_TO_INI_MOUNT_POINT
|
|
value: /env-to-ini-mounts
|
|
- it: Deployment with standard additionalConfigFromEnvs
|
|
template: templates/gitea/deployment.yaml
|
|
set:
|
|
gitea.additionalConfigFromEnvs: [{name: GITEA_database_HOST, value: my-db:123}, {name: GITEA_database_USER, value: my-user}]
|
|
asserts:
|
|
- hasDocuments:
|
|
count: 1
|
|
- exists:
|
|
path: spec.template.spec.initContainers[1].env
|
|
- lengthEqual:
|
|
path: spec.template.spec.initContainers[1].env
|
|
count: 8
|
|
- isSubset:
|
|
path: spec.template.spec.initContainers[1]
|
|
content:
|
|
env:
|
|
- name: GITEA_APP_INI
|
|
value: /data/gitea/conf/app.ini
|
|
- name: GITEA_CUSTOM
|
|
value: /data/gitea
|
|
- name: GITEA_WORK_DIR
|
|
value: /data
|
|
- name: GITEA_TEMP
|
|
value: /tmp/gitea
|
|
- name: TMP_EXISTING_ENVS_FILE
|
|
value: /tmp/existing-envs
|
|
- name: ENV_TO_INI_MOUNT_POINT
|
|
value: /env-to-ini-mounts
|
|
- name: GITEA_database_HOST
|
|
value: my-db:123
|
|
- name: GITEA_database_USER
|
|
value: my-user
|
|
- it: Deployment with templated additionalConfigFromEnvs
|
|
template: templates/gitea/deployment.yaml
|
|
set:
|
|
gitea.misc.host: my-db-host:321
|
|
gitea.misc.user: my-db-user
|
|
gitea.additionalConfigFromEnvs: [{name: GITEA_database_HOST, value: "{{ .Values.gitea.misc.host }}"}, {name: GITEA_database_USER, value: "{{ .Values.gitea.misc.user }}"}]
|
|
asserts:
|
|
- hasDocuments:
|
|
count: 1
|
|
- exists:
|
|
path: spec.template.spec.initContainers[1].env
|
|
- lengthEqual:
|
|
path: spec.template.spec.initContainers[1].env
|
|
count: 8
|
|
- isSubset:
|
|
path: spec.template.spec.initContainers[1]
|
|
content:
|
|
env:
|
|
- name: GITEA_APP_INI
|
|
value: /data/gitea/conf/app.ini
|
|
- name: GITEA_CUSTOM
|
|
value: /data/gitea
|
|
- name: GITEA_WORK_DIR
|
|
value: /data
|
|
- name: GITEA_TEMP
|
|
value: /tmp/gitea
|
|
- name: TMP_EXISTING_ENVS_FILE
|
|
value: /tmp/existing-envs
|
|
- name: ENV_TO_INI_MOUNT_POINT
|
|
value: /env-to-ini-mounts
|
|
- name: GITEA_database_HOST
|
|
value: my-db-host:321
|
|
- name: GITEA_database_USER
|
|
value: my-db-user
|
|
- it: Deployment with additionalConfigFromEnvs templated secret name
|
|
template: templates/gitea/deployment.yaml
|
|
set:
|
|
gitea.misc.existingSecret: my-db-secret
|
|
gitea.additionalConfigFromEnvs[0]:
|
|
name: GITEA_database_HOST
|
|
valueFrom:
|
|
secretKeyRef:
|
|
name: "{{ .Values.gitea.misc.existingSecret }}"
|
|
key: password
|
|
asserts:
|
|
- hasDocuments:
|
|
count: 1
|
|
- exists:
|
|
path: spec.template.spec.initContainers[1].env
|
|
- lengthEqual:
|
|
path: spec.template.spec.initContainers[1].env
|
|
count: 7
|
|
- isSubset:
|
|
path: spec.template.spec.initContainers[1]
|
|
content:
|
|
env:
|
|
- name: GITEA_APP_INI
|
|
value: /data/gitea/conf/app.ini
|
|
- name: GITEA_CUSTOM
|
|
value: /data/gitea
|
|
- name: GITEA_WORK_DIR
|
|
value: /data
|
|
- name: GITEA_TEMP
|
|
value: /tmp/gitea
|
|
- name: TMP_EXISTING_ENVS_FILE
|
|
value: /tmp/existing-envs
|
|
- name: ENV_TO_INI_MOUNT_POINT
|
|
value: /env-to-ini-mounts
|
|
- name: GITEA_database_HOST
|
|
valueFrom:
|
|
secretKeyRef:
|
|
name: "my-db-secret"
|
|
key: password
|