The names of the Secrets rendered by the chart were built inline in each template and, for two of them, in ad-hoc chart-wide helpers. The same name therefore existed in several places (Deployment volumes, ServiceMonitor credentials, the Secret templates themselves), which made every rename a multi-file change and allowed the references to drift apart unnoticed - the Helm unit tests render one template at a time and cannot detect a mismatching secretName. All Secret names are now defined once in templates/gitea/_secrets.tpl: gitea.secret.config.name -> <fullname>-config gitea.secret.gpg.name -> <fullname>-gpg-key (or signing.existingSecret) gitea.secret.init.name -> <fullname>-init gitea.secret.inlineConfig.name -> <fullname>-inline-config gitea.secret.metrics.name -> <fullname>-metrics gitea.gpg-key-secret-name and gitea.metrics-secret-name are removed from _helpers.tpl accordingly. A checksum/inlineConfig pod annotation is added as well. After the inline configuration had been split out of secret_config.yaml, changes to it were no longer covered by any checksum annotation and did not trigger a rollout of the Deployment. Finally the metadata attributes of the Secret templates are sorted alphabetically as required by the chart conventions. BREAKING CHANGE: two Secrets are renamed. The config Secret changes from <fullname> to <fullname>-config and the metrics Secret from <fullname>-metrics-secret to <fullname>-metrics. Helm replaces both on upgrade; references to them from outside the chart have to be adjusted. Co-authored-by: Copilot <copilot@github.com>
190 lines
5.5 KiB
YAML
190 lines
5.5 KiB
YAML
suite: deployment template (probes)
|
|
release:
|
|
name: gitea-unittests
|
|
namespace: testing
|
|
templates:
|
|
- templates/gitea/deployment.yaml
|
|
- templates/gitea/secret_config.yaml
|
|
- templates/gitea/secret_inlineConfig.yaml
|
|
tests:
|
|
- it: renders default liveness probe
|
|
template: templates/gitea/deployment.yaml
|
|
asserts:
|
|
- notExists:
|
|
path: spec.template.spec.containers[0].livenessProbe.enabled
|
|
- isSubset:
|
|
path: spec.template.spec.containers[0].livenessProbe
|
|
content:
|
|
failureThreshold: 10
|
|
initialDelaySeconds: 200
|
|
periodSeconds: 10
|
|
successThreshold: 1
|
|
tcpSocket:
|
|
port: http
|
|
timeoutSeconds: 1
|
|
- it: renders default readiness probe
|
|
template: templates/gitea/deployment.yaml
|
|
asserts:
|
|
- notExists:
|
|
path: spec.template.spec.containers[0].readinessProbe.enabled
|
|
- isSubset:
|
|
path: spec.template.spec.containers[0].readinessProbe
|
|
content:
|
|
failureThreshold: 3
|
|
initialDelaySeconds: 5
|
|
periodSeconds: 10
|
|
successThreshold: 1
|
|
tcpSocket:
|
|
port: http
|
|
timeoutSeconds: 1
|
|
- it: does not render a default startup probe
|
|
template: templates/gitea/deployment.yaml
|
|
asserts:
|
|
- notExists:
|
|
path: spec.template.spec.containers[0].startupProbe
|
|
- it: allows enabling a startup probe
|
|
template: templates/gitea/deployment.yaml
|
|
set:
|
|
gitea.startupProbe.enabled: true
|
|
asserts:
|
|
- notExists:
|
|
path: spec.template.spec.containers[0].startupProbe.enabled
|
|
- isSubset:
|
|
path: spec.template.spec.containers[0].startupProbe
|
|
content:
|
|
failureThreshold: 10
|
|
initialDelaySeconds: 60
|
|
periodSeconds: 10
|
|
successThreshold: 1
|
|
tcpSocket:
|
|
port: http
|
|
timeoutSeconds: 1
|
|
|
|
- it: allows overwriting the default port of the liveness probe
|
|
template: templates/gitea/deployment.yaml
|
|
set:
|
|
gitea:
|
|
livenessProbe:
|
|
tcpSocket:
|
|
port: my-port
|
|
asserts:
|
|
- isSubset:
|
|
path: spec.template.spec.containers[0].livenessProbe
|
|
content:
|
|
tcpSocket:
|
|
port: my-port
|
|
|
|
- it: allows overwriting the default port of the readiness probe
|
|
template: templates/gitea/deployment.yaml
|
|
set:
|
|
gitea:
|
|
readinessProbe:
|
|
tcpSocket:
|
|
port: my-port
|
|
asserts:
|
|
- isSubset:
|
|
path: spec.template.spec.containers[0].readinessProbe
|
|
content:
|
|
tcpSocket:
|
|
port: my-port
|
|
|
|
- it: allows overwriting the default port of the startup probe
|
|
template: templates/gitea/deployment.yaml
|
|
set:
|
|
gitea:
|
|
startupProbe:
|
|
enabled: true
|
|
tcpSocket:
|
|
port: my-port
|
|
asserts:
|
|
- isSubset:
|
|
path: spec.template.spec.containers[0].startupProbe
|
|
content:
|
|
tcpSocket:
|
|
port: my-port
|
|
|
|
- it: allows using a non-default method as liveness probe
|
|
template: templates/gitea/deployment.yaml
|
|
set:
|
|
gitea:
|
|
livenessProbe:
|
|
httpGet:
|
|
path: /api/healthz
|
|
port: http
|
|
initialDelaySeconds: 13371
|
|
timeoutSeconds: 13372
|
|
periodSeconds: 13373
|
|
successThreshold: 13374
|
|
failureThreshold: 13375
|
|
asserts:
|
|
- notExists:
|
|
path: spec.template.spec.containers[0].livenessProbe.tcpSocket
|
|
- isSubset:
|
|
path: spec.template.spec.containers[0].livenessProbe
|
|
content:
|
|
failureThreshold: 13375
|
|
initialDelaySeconds: 13371
|
|
periodSeconds: 13373
|
|
successThreshold: 13374
|
|
httpGet:
|
|
path: /api/healthz
|
|
port: http
|
|
timeoutSeconds: 13372
|
|
|
|
- it: allows using a non-default method as readiness probe
|
|
template: templates/gitea/deployment.yaml
|
|
set:
|
|
gitea:
|
|
readinessProbe:
|
|
httpGet:
|
|
path: /api/healthz
|
|
port: http
|
|
initialDelaySeconds: 13371
|
|
timeoutSeconds: 13372
|
|
periodSeconds: 13373
|
|
successThreshold: 13374
|
|
failureThreshold: 13375
|
|
asserts:
|
|
- notExists:
|
|
path: spec.template.spec.containers[0].readinessProbe.tcpSocket
|
|
- isSubset:
|
|
path: spec.template.spec.containers[0].readinessProbe
|
|
content:
|
|
failureThreshold: 13375
|
|
initialDelaySeconds: 13371
|
|
periodSeconds: 13373
|
|
successThreshold: 13374
|
|
httpGet:
|
|
path: /api/healthz
|
|
port: http
|
|
timeoutSeconds: 13372
|
|
|
|
- it: allows using a non-default method as startup probe
|
|
template: templates/gitea/deployment.yaml
|
|
set:
|
|
gitea:
|
|
startupProbe:
|
|
enabled: true
|
|
httpGet:
|
|
path: /api/healthz
|
|
port: http
|
|
initialDelaySeconds: 13371
|
|
timeoutSeconds: 13372
|
|
periodSeconds: 13373
|
|
successThreshold: 13374
|
|
failureThreshold: 13375
|
|
asserts:
|
|
- notExists:
|
|
path: spec.template.spec.containers[0].startupProbe.tcpSocket
|
|
- isSubset:
|
|
path: spec.template.spec.containers[0].startupProbe
|
|
content:
|
|
failureThreshold: 13375
|
|
initialDelaySeconds: 13371
|
|
periodSeconds: 13373
|
|
successThreshold: 13374
|
|
httpGet:
|
|
path: /api/healthz
|
|
port: http
|
|
timeoutSeconds: 13372
|