The chart conventions demand camelCase file names, forbid short names like `svc` and require the unit tests to
mirror the template structure. The unit tests followed none of that consistently. Four casings existed side by
side - camelCase (extraInitContainers.yaml), kebab-case (checksum-annotations.yaml), a snake and kebab mix
(init_directory_structure.sh-rootless.yaml) and all caps (HA.yaml) - so there was no pattern to copy when
adding a suite, which is how the inconsistency kept growing.
Three groups of problems are fixed:
- svc-configuration.yaml used exactly the short name the conventions forbid for files and keys.
- Several file names repeated their own directory, for example deployment/deployment-additional-config.yaml and
metric-secret/metrics-secret-servicemonitor-disabled.yaml, which names the subject three times. The directory
already carries that information, so the file name now only carries the scenario. The default scenario of a
template is named basics.yaml.
- Four suites lived in a directory of a template they do not assert on. They were filed under deployment/
because the deployment is rendered as a side effect, not because it is the subject:
deployment/deprecations.yaml -> deprecation/deployment.yaml
deployment/inline-config.yaml -> config/inlineConfig.yaml
deployment/storage-class-configuration.yaml -> persistentVolumeClaim/storageClass.yaml
deployment/svc-configuration.yaml -> service/configuration.yaml
storage-class-configuration.yaml is the clearest case: a persistentVolumeClaim directory already existed next
to it. The suite titles of the two suites whose subject changed are adjusted accordingly.
The Makefile passed `--file unittests/helm/values-conflicting-checks.yaml`, but that file does not exist in the
tree. `helm unittest` ignores a missing path without a warning, so the flag has been dead for an unknown amount
of time while still suggesting the checks run. It is removed; the `unittests/helm/**/*.yaml` glob would pick
the file up anyway if it ever returns.
The naming rule is written down in the copilot instructions, together with the constraint that the glob matches
only a single directory level, so a suite can never be placed directly in unittests/helm/.
All 49 suites and 267 tests still pass.
Co-authored-by: Copilot <copilot@github.com>
5.1 KiB
5.1 KiB
Gitea Helm Chart — Copilot Instructions
Project Overview
Kubernetes Helm chart for deploying Gitea. Uses Go/Helm templating (templates/), YAML values (values.yaml), and includes sub-charts for PostgreSQL, PostgreSQL-HA, Valkey, and Valkey-cluster.
Build & Test
make missing-dot # Check if the @param annotations are missing a trailing dot.
make readme # Regenerate README.md parameter table + lint + link checker
make helm/unittest # Run Helm unit tests (helm-unittest plugin required)
make bash/unittest # Run bash/bats script tests (requires git submodule init)
Always run make readme after changing values.yaml @param annotations.
Always run make helm/unittest after changing templates or unit tests.
Conventions
values.yaml
- Use
## @param path.to.key Descriptionannotations for every user-facing value. These drive the auto-generated README parameter table. - Property ordering within a resource block:
enabled,annotations,labelsfirst, then type-specific fields. - Top-level keys are sorted alphabetically within their section group.
- Use Helm Values pattern from renovatebot. Ensure that the attributes
registry,repositoryandtagare available as part of the dictimage. For example:
image:
registry: docker.io
repository: library/busybox
tag: 0.1.0
Templates
- Helm templates live in
templates/. Helpers live intemplates/_helpers.tpl. - Use camelCase for all files and variables (e.g
httpRoute,backendTLSPolicy,gatewayAPI,statefulSet). - Use
include "gitea.fullname"for naming resources. - Use
failfor required-value validation with clear error messages referencing the full values path. - Ensure, that the attributes
annotations,labels,nameandnamespaceare alphabetically sorted. - Render all attributes, even if they are empty, to prevent drift in Argo CD. For example,
labelsmust be rendered, whileannotationsare defined asyaml:"annotations,omitempty". - Use plural for
*.tplfiles, because they may contain functions for multiple resources of the same kind (e.g._services.tplforhttpService.yamlorsshService.yaml,_backendTLSPolicies.tplforbackendTLSPolicy.yaml). - Use as prefix of YAML files the resource kind (e.g.,
deployment.yamlforDeploymentresources). If there are multiple resources of the same kind, use a descriptive suffix (e.g.,deployment_metrics.yamlfor aDeploymentrelated to metrics). - Short names like
pvcfor Persistent Volume Claims orsvcfor Services are not allowed in file names or key names. - Render
Secretpayloads as base64dataand never asstringData. The API server dropsstringDataand persists everything underdata, so Helm's three-way merge cannot prune a key that was removed from the values — the stale key survives every upgrade. For example:
data:
app.ini: {{ $config | b64enc }}
Unit Tests
- Helm unit tests live in
unittests/helm/mirroring the template structure. A suite belongs into the directory of the template it asserts on, never into the directory of a template it only renders as a side effect. - Test files are YAML using the helm-unittest format.
- Name test files in camelCase after the scenario they cover (e.g.
signingEnabled.yaml), usebasics.yamlfor the default scenario and do not repeat the directory name in the file name. Themake helm/unittestglob only matches one directory level, so every suite must live in a subdirectory. - Each test must set all required values explicitly — do not rely on cross-test state.
- The
values.yamlfile must passyamllint. The configuration is in.yamllint.yaml. Usemake yamllintto run the linter. - The title of the unit test should clearly describe the scenario being tested. As title must be use a short sentence starting with a capital letter and ending without a period.
- The
suitetitle follows the patternTest <subject> <scenario>(e.g.Test deployment probes). It must be unique across all suites, becausehelm unittestidentifies a failing suite by this title. - Each unit test must explicitly set a custom namespace and release name, rather than relying on defaults.
- Assert
Secretcontent viadata.*withdecodeBase64: trueand add anotExistsassertion forstringData.
Commits & PRs
- Follow Conventional Commits for PR titles and commit messages (e.g.
feat:,fix:,refactor:,docs:,style:). - See
CONTRIBUTING.mdfor full PR requirements. - Explain in detail why a change is needed, not just what the change is. Include links to relevant issues, PRs, or external references.
- Add co-authors for any contributions that are not your own. Use the
Co-authored-by:trailer in the commit message.
Documentation
docs/contains topic-specific guides (e.g.gateway-api.md,ha-setup.md).README.mdparameter tables are auto-generated — never edit them manually.